Skip to content

Add _filter_kwargs method to IStructure for better kwargs handling#21

Open
cogsworth37 wants to merge 1 commit intomaterialsproject:mainfrom
cogsworth37:4551-fix-from_file-crash
Open

Add _filter_kwargs method to IStructure for better kwargs handling#21
cogsworth37 wants to merge 1 commit intomaterialsproject:mainfrom
cogsworth37:4551-fix-from_file-crash

Conversation

@cogsworth37
Copy link
Copy Markdown

Summary

Major changes:

Fixes materialsproject/pymatgen#4551

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

@cogsworth37 cogsworth37 marked this pull request as ready for review April 10, 2026 02:03
@cogsworth37 cogsworth37 requested a review from shyuep as a code owner April 10, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Structure.from_file() fails if frac_tolerance argument supplied and file is POSCAR

1 participant