Skip to content

[numkong] update to 2.7.0 #50998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
toge wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −10
Draft

[numkong] update to 2.7.0 #50998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions ports/numkong/export-target.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,26 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
index dfbc4a2..92c84aa 100644
index bbd1f21..f66b914 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -225,7 +225,7 @@ target_sources(numkong INTERFACE ${NK_SOURCES})
target_include_directories(numkong INTERFACE "${PROJECT_SOURCE_DIR}/include")
@@ -232,7 +232,7 @@ if (MSVC)
endif ()

# Enable Clang C modules for incremental compilation
-if (CMAKE_C_COMPILER_ID MATCHES "Clang")
+if (FALSE)
target_compile_options(
numkong INTERFACE $<$<COMPILE_LANGUAGE:C>:-fmodules> $<$<COMPILE_LANGUAGE:C>:-fimplicit-module-maps>
$<$<COMPILE_LANGUAGE:C>:-fmodules-cache-path=${CMAKE_BINARY_DIR}/module-cache>
@@ -606,7 +606,7 @@ if (NK_BUILD_SHARED)
@@ -567,7 +567,7 @@ if (NK_BUILD_SHARED)
)

add_executable(nk_shared ${NK_SOURCES} "${CMAKE_BINARY_DIR}/emscripten_stub.c")
- target_include_directories(nk_shared PUBLIC "${PROJECT_SOURCE_DIR}/include")
+ target_include_directories(nk_shared PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include> $<INSTALL_INTERFACE:include>)

if (NK_WASM64_)
set_target_properties(
@@ -613,7 +613,7 @@ if (NK_BUILD_SHARED)
endif ()
else ()
add_library(nk_shared SHARED ${NK_SOURCES})
Expand All @@ -20,7 +29,7 @@ index dfbc4a2..92c84aa 100644
set_target_properties(nk_shared PROPERTIES OUTPUT_NAME numkong)

# Hide all symbols by default; only NK_DYNAMIC-annotated API functions are exported.
@@ -658,15 +658,21 @@ if (NK_BUILD_SHARED)
@@ -665,15 +665,22 @@ if (NK_BUILD_SHARED)

install(
TARGETS nk_shared
Expand All @@ -29,8 +38,8 @@ index dfbc4a2..92c84aa 100644
+ ARCHIVE DESTINATION lib
BUNDLE
FRAMEWORK
- LIBRARY
+ LIBRARY DESTINATION lib
LIBRARY
Comment on lines 41 to +42
Copy link
Copy Markdown
Member

@vicroms vicroms Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this line have been removed in the patch?

OBJECTS
PRIVATE_HEADER
PUBLIC_HEADER
Expand All @@ -45,7 +54,7 @@ index dfbc4a2..92c84aa 100644
)
endif ()

@@ -692,5 +698,4 @@ if (NK_BUILD_SHARED_TEST)
@@ -699,5 +706,4 @@ if (NK_BUILD_SHARED_TEST)
add_test(NAME nk_shared_test COMMAND nk_shared_test)
endif ()

Expand Down
2 changes: 1 addition & 1 deletion ports/numkong/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO ashvardanian/NumKong
REF "v${VERSION}"
SHA512 e3514bd8520babdb47058c5693eb329d57053d45640f300db38a9704ecf427b40ac2f0c1f8f5c28a8feb5a8bdd38b5fb2a52577ca0ace56d47bdbbe4178b6fcf
SHA512 5af620701996ea1ca7df4bcada0303d4560d0f50e5a48489c30990a3991a67f2a66f7a7683ac1b5c5d7f5153864b0349b9e85c117402ec4a9b72442021f917fe
HEAD_REF main
PATCHES
export-target.patch
Expand Down
2 changes: 1 addition & 1 deletion ports/numkong/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "numkong",
"version": "7.3.0",
"version": "7.4.4",
"description": "NumKong (previously SimSIMD) delivers mixed-precision numerics that are often faster and more accurate than standard BLAS libraries",
"homepage": "https://github.com/ashvardanian/NumKong",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7069,7 +7069,7 @@
"port-version": 0
},
"numkong": {
"baseline": "7.3.0",
"baseline": "7.4.4",
"port-version": 0
},
"nuraft": {
Expand Down
5 changes: 5 additions & 0 deletions versions/n-/numkong.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "89cbd2055b8d863aef1ac063111f05a7d0ef485d",
"version": "7.4.4",
"port-version": 0
},
{
"git-tree": "d8a97a83c6a684230df214d40f82386fe3a797ac",
"version": "7.3.0",
Expand Down