[gtk] add wayland support on linux#51039
Conversation
|
@microsoft-github-policy-service agree |
|
apparently the wayland version by the wayland distro in the CI is too old. What should be the fix here? |
| set(osx false) | ||
| if(VCPKG_TARGET_IS_LINUX) | ||
| set(OPTIONS -Dwayland-backend=false) # CI missing at least wayland-protocols | ||
| set(wayland true) |
There was a problem hiding this comment.
Why this should be always enabled by default? It is still possible to build GTK with X11 backend, and thus this port should give a possibility to do that, and not just hardcode Wayland for Linux
There was a problem hiding this comment.
Well, currently x11 is also hardcoded for linux. When enabling wayland that does not disable x11, it just enables both backends. So on a X11 desktop GTK would pick the x11 backend, on a wayland desktop the wayland backend (currently it quits there).
Ideally we'd want VCPKG features for the backend selection, but in general this port currently lacks any proper feature support. E.g. vulkan, opengl etc. should also be selectable.
To me it seemed like this is out of scope of this PR
There was a problem hiding this comment.
By this change you will force all applications to build (or install) Wayland even if they don't use it, so this is a breaking change. Also can you confirm that with Wayland backend application will switch to X11 when there is not Wayland support and what is more important will not require installing anything additional?
There was a problem hiding this comment.
I can confirm this since i've used Gtk (without VCPKG) for years. The automatic backend selection is the default behaviour unless explicitly set: https://docs.gtk.org/gtk4/running.html#gdk_backend
This port not having features forces a lot of restrictions. My distro has no X11 support, still this port forces me to build & compile the x11 backend.
If majority wants me to pull this out as a feature I'll do so, but then the other backends should be "optional" aswell
There was a problem hiding this comment.
And in this port you explicitly wet it to use Wayland. I do know that on Wayland X11 applications can run because Wayland provides a special mediator library.
I'm not sure this will work other way around when you build an application setting a Wayland backend that ill fall back to X11 if Wayland is not present.
To clarify: I'm ok to have Wayland a defaul backend, but there should be a possibility to configure this port to use some other backend.
If majority wants me to pull this out as a feature I'll do so, but then the other backends should be "optional" aswell
This is basically up to maintainers to decide.
However, the only 'other' backend is broadway, since macos is MacOs specific, and win32 is Windows specific.
There was a problem hiding this comment.
I agree with you that features would be sweet, the question is just if this is in scope of this PR.
To have all Gtk build options represented as features would require us to add more than 10+ features probably (e.g. the renderer choice etc.)
There was a problem hiding this comment.
You don't need to do anything in one PR. You can start with backend options and add other features later.
I mean, if you do this change now, it will be visible immediately (ok, for the majority of users after the next monthly release), and at that point it will be too late to improve something since the only option will be the rollback.
Regarding the other features, if would be nice to have them if they are required.
There was a problem hiding this comment.
These are things I believe to be true:
- Wayland is the future of graphics on Linux. Most distros currently ship with Wayland by default.
- Fedora since 25: https://docs.fedoraproject.org/en-US/quick-docs/configuring-xorg-as-default-gnome-session/
- Ubuntu doesn't seem to document so easily but random googling suggests since at least 24.Xxx . See also https://itsfoss.com/news/ubuntu-25-10-wayland-only/
- Debian 10 and later https://wiki.debian.org/Xorg . Note that the GTK Debian packages ( https://packages.debian.org/sid/libgtk-4-1 ) depend on both X and Wayland.
- As a result of the above, X11 outside of "compatibility modes" is dying. It's certainly dying as an expected end user configuration.
There is some time where we would have had to change the backend we choose out of the box, and now that all of the major distros are done so, I think we should. I understand that is exceedingly unfortunate for @AenBleidd 's use case where vcpkg was building all of the X related libraries he needs, but given the GTK maintainer's statement linked above ( gtk-rs/gtk4-rs#1963 (comment) ) that seems like a strong statement that is not the expected user base from their perspective.
EDIT: But if even Ubuntu 22.04 "Noble"'s Wayland is too old we might have no good options?
To that end, I think we should change this to Wayland and/or both. portfile.cmake can have an option or something to make it easy for folks in @AenBleidd 's scenario to maintain an overlay port.
There was a problem hiding this comment.
I'm not happy with that but that's fair enough. My suggestion would be at least to announce it somewhere before merging that people are aware beforehand and not just awake in the morning to see all their builds failed not knowing what they need to do next to fix them all (I know about version pinning but let's be honest: it doesn't really work since you cannot fix a particular version of particular library without affecting other libraries).
Anyway, @BillyONeal, thank you for the detailed analysis and sorry for any possible mess.
There was a problem hiding this comment.
@BillyONeal, a little piece of information for you.
When I last tried to build Wayland (like really build without system packages installed), it was failed due to broken ports (see my comment here).
Not sure how much this is relevant now but worth taking a look I support since you want to enforce Wayland.
vicroms
added
the
requires:vcpkg-team-review
We are using Ubuntu 22.04 "Noble Numbat". Is that really too old or is it just that we didn't install something? |
4 participants
Fixes #51038
./vcpkg x-add-version --alland committing the result.