Open
Conversation
dg0yt
reviewed
Apr 9, 2026
Contributor
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
Nitpick: When updating the patch, try to avoid unnecessary whitespace changes (removing/moving empty lines).
| # Add the library to the project | ||
| -add_library(wincpp STATIC) | ||
| +add_library(wincpp) | ||
| +set_target_properties(wincpp PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS ON) |
Contributor
There was a problem hiding this comment.
Reminder, this is not accepted in vcpkg.
https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#do-not-add-cmake_windows_export_all_symbols
(That CMake variable determines the propery.)
| +set(wincpp_CONFFILE_DEST "${CMAKE_INSTALL_DATAROOTDIR}/wincpp") | ||
| + | ||
| +install(FILES | ||
| + "${CMAKE_CURRENT_BINARY_DIR}/wincppConfig.cmake" |
Contributor
There was a problem hiding this comment.
Reminder, the "unofficial" prefix must be used for config and targets unless provided officially by upstream.
Comment on lines
+14
to
+15
| -DBUILD_EXAMPLES=OFF | ||
| -DBUILD_PACKAGE=OFF |
Contributor
There was a problem hiding this comment.
Suggested change
| -DBUILD_EXAMPLES=OFF | |
| -DBUILD_PACKAGE=OFF | |
| -DBUILD_EXAMPLES=OFF | |
| -DBUILD_PACKAGE=OFF |
Comment on lines
+18
to
+19
| -target_sources(_wincpp_core INTERFACE ${header_files}) | ||
| +target_sources(_wincpp_core INTERFACE $<BUILD_INTERFACE:${header_files}>) |
Contributor
There was a problem hiding this comment.
Hm, what did upstream want to achieve? Is it still achieved after this change? Do we need a test port?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [] Optional dependencies of the build are all controlled by the port. A dependency is controlled if it is declared an unconditional dependency invcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGEvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.