Client Backpressure #1918
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -172,7 +172,8 @@ private InternalConnectionInitializationDescription createInitializationDescript | |
|
|
||
| private BsonDocument createHelloCommand(final Authenticator authenticator, final InternalConnection connection) { | ||
| BsonDocument helloCommandDocument = new BsonDocument(getHandshakeCommandName(), new BsonInt32(1)) | ||
| .append("helloOk", BsonBoolean.TRUE) | ||
| .append("backpressure", BsonBoolean.TRUE); | ||
|
Member
Author
There was a problem hiding this comment. The commit ac1c120 introduced by #1906 for JAVA-6035 should have implemented, as far as I understand, the If the above is correct, let's reopen JAVA-6035 and create another PR for that ticket that will implement the prose test.
Collaborator
There was a problem hiding this comment. Thanks for catching this. I reopened https://jira.mongodb.org/browse/JAVA-6035 |
||
| if (clientMetadataDocument != null) { | ||
| helloCommandDocument.append("client", clientMetadataDocument); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,7 +37,9 @@ | |
| import static org.junit.jupiter.api.Assertions.fail; | ||
| import static org.junit.jupiter.api.Assumptions.assumeTrue; | ||
|
|
||
| /** | ||
| * <a href="https://github.com/mongodb/specifications/blob/master/source/transactions-convenient-api/tests/README.md#prose-tests">Prose Tests</a>. | ||
| */ | ||
| public class WithTransactionProseTest extends DatabaseTestCase { | ||
|
Collaborator
There was a problem hiding this comment.
|
||
| private static final long START_TIME_MS = 1L; | ||
| private static final long ERROR_GENERATING_INTERVAL = 121000L; | ||
|
|
@@ -52,11 +54,10 @@ public void setUp() { | |
| collection.insertOne(Document.parse("{ _id : 0 }")); | ||
| } | ||
|
|
||
| /** | ||
| * <a href="https://github.com/mongodb/specifications/blob/master/source/transactions-convenient-api/tests/README.md#callback-raises-a-custom-error"> | ||
| * Callback Raises a Custom Error</a>. | ||
| */ | ||
| @Test | ||
| public void testCallbackRaisesCustomError() { | ||
| final String exceptionMessage = "NotTransientOrUnknownError"; | ||
|
|
@@ -71,10 +72,10 @@ public void testCallbackRaisesCustomError() { | |
| } | ||
| } | ||
|
|
||
| /** | ||
| * <a href="https://github.com/mongodb/specifications/blob/master/source/transactions-convenient-api/tests/README.md#callback-returns-a-value"> | ||
| * Callback Returns a Value</a>. | ||
| */ | ||
| @Test | ||
| public void testCallbackReturnsValue() { | ||
| try (ClientSession session = client.startSession()) { | ||
|
|
@@ -87,10 +88,10 @@ public void testCallbackReturnsValue() { | |
| } | ||
| } | ||
|
|
||
| /** | ||
| * <a href="https://github.com/mongodb/specifications/blob/master/source/transactions-convenient-api/tests/README.md#retry-timeout-is-enforced"> | ||
| * Retry Timeout is Enforced</a>, first scenario on the list. | ||
| */ | ||
| @Test | ||
| public void testRetryTimeoutEnforcedTransientTransactionError() { | ||
| final String errorMessage = "transient transaction error"; | ||
|
|
@@ -110,10 +111,10 @@ public void testRetryTimeoutEnforcedTransientTransactionError() { | |
| } | ||
| } | ||
|
|
||
| /** | ||
| * <a href="https://github.com/mongodb/specifications/blob/master/source/transactions-convenient-api/tests/README.md#retry-timeout-is-enforced"> | ||
| * Retry Timeout is Enforced</a>, second scenario on the list. | ||
| */ | ||
| @Test | ||
| public void testRetryTimeoutEnforcedUnknownTransactionCommit() { | ||
| MongoDatabase failPointAdminDb = client.getDatabase("admin"); | ||
|
|
@@ -137,11 +138,10 @@ public void testRetryTimeoutEnforcedUnknownTransactionCommit() { | |
| } | ||
| } | ||
|
|
||
| /** | ||
| * <a href="https://github.com/mongodb/specifications/blob/master/source/transactions-convenient-api/tests/README.md#retry-timeout-is-enforced"> | ||
| * Retry Timeout is Enforced</a>, third scenario on the list. | ||
| */ | ||
| @Test | ||
| public void testRetryTimeoutEnforcedTransientTransactionErrorOnCommit() { | ||
| MongoDatabase failPointAdminDb = client.getDatabase("admin"); | ||
|
|
@@ -166,9 +166,9 @@ public void testRetryTimeoutEnforcedTransientTransactionErrorOnCommit() { | |
| } | ||
| } | ||
|
|
||
| /** | ||
| * Ensure cannot override timeout in transaction. | ||
| */ | ||
| @Test | ||
| public void testTimeoutMS() { | ||
| try (ClientSession session = client.startSession(ClientSessionOptions.builder() | ||
|
|
@@ -182,9 +182,9 @@ public void testTimeoutMS() { | |
| } | ||
| } | ||
|
|
||
| /** | ||
| * Ensure legacy settings don't cause issues in sessions. | ||
| */ | ||
| @Test | ||
| public void testTimeoutMSAndLegacySettings() { | ||
| try (ClientSession session = client.startSession(ClientSessionOptions.builder() | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO-BACKPRESSURE ValentinBefore merging in
main, make sure that all the code in thebackpressurebranch uses theMongoException.TRANSIENT_TRANSACTION_ERROR_LABEL/UNKNOWN_TRANSACTION_COMMIT_RESULT_LABEL/SYSTEM_OVERLOADED_ERROR_LABEL/RETRYABLE_ERROR_LABELandCommandOperationHelper.RETRYABLE_WRITE_ERROR_LABEL/NO_WRITES_PERFORMED_ERROR_LABELconstants instead of using theTransientTransactionError/UnknownTransactionCommitResult/SystemOverloadedError/RetryableErrorandRetryableWriteError/NoWritesPerformedliterals.