SERVER-84018 Add multiPlannerFallbackEngaged flag to slow query log#1639
SERVER-84018 Add multiPlannerFallbackEngaged flag to slow query log#1639chriszeng1010 wants to merge 1 commit intomongodb:masterfrom
Conversation
jstests/noPassthrough/query/query_settings_fallback_profiler.js
Outdated
Show resolved
Hide resolved
458ca83 to
68ee11b
Compare
|
Hey @chriszeng1010 - thanks for the pull request! To consider your PR, can you sign our Contributor's Agreement? I see you already referenced the SERVER ticket, so I'll check on that |
|
Signed |
denis631
left a comment
There was a problem hiding this comment.
Nice work @chriszeng1010!
Thank you for your contribution and apologies for the delay!
I will run your patch on the CI and will approve as soon as it passes 💪
jstests/noPassthrough/query/query_settings_fallback_profiler.js
Outdated
Show resolved
Hide resolved
When query settings are present for a query shape but fail to produce a valid plan, the planner falls back to multi-planning without those settings. This change adds a flag to the slow query log and profiler to indicate when this fallback was engaged.
68ee11b to
b85f200
Compare
|
@chriszeng1010 just wanted to give you the heads up, that the PR is going through internal approval. Let me know ifyou would like to change that |
|
Yea got it.
is fine with me unless if you guys have a better recommendation |
Summary
multiPlannerFallbackEngagedboolean flag to the slow query log and database profiler outputtruewhen query settings exist for a query shape but fail to produce a valid execution plan, causing the planner to fall back to multi-planning without those settingsChanges
multiPlannerFallbackEngagedfield directly onOpDebugreport()(slow query log) andappend()(profiler)NoQueryExecutionPlanscatch block when query settings are removed and planning is retriedTest plan
truein profilerquery_settings_fallback_profiler.jsintegration test