fix(browser): reject duplicate setupWorker calls#2681
Open
trknhr wants to merge 2 commits intomswjs:mainfrom
Open
fix(browser): reject duplicate setupWorker calls#2681trknhr wants to merge 2 commits intomswjs:mainfrom
trknhr wants to merge 2 commits intomswjs:mainfrom
Conversation
Guard setupWorker with a page-global symbol so repeated initialization fails fast instead of creating conflicting browser worker state. Add a browser regression test that covers the duplicate call path while asserting only on a stable error prefix. Fixes mswjs#2585
Rename the page-global setupWorker guard symbol to reflect that it stores an applied marker, not a worker instance. This keeps the singleton check aligned with the existing key-style naming in the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject duplicate
setupWorker()calls in the same page by guarding initialization with a page-global symbol. This makes the failure explicit before multiple worker instances can attach conflicting browser-side listeners.The browser worker state is shared per page, so creating multiple setupWorker instances is ambiguous and leads to clashing request handling. Failing fast here keeps
setupWorker()as a single-construction API and points users toward reusing the existing worker withworker.use()orworker.resetHandlers().This also adds a browser regression test for the duplicate call path while asserting only on a stable error prefix so the developer-facing guidance can still evolve.
Fixes #2585