Update string size arguments for Svc Components to match configuration values in FPP#4804
Draft
timcanham wants to merge 5 commits intonasa:develfrom
Draft
Update string size arguments for Svc Components to match configuration values in FPP#4804timcanham wants to merge 5 commits intonasa:develfrom
timcanham wants to merge 5 commits intonasa:develfrom
Conversation
LeStarch
added
Deferred To Future Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Update some string length arguments to tie them to FPP constants
Rationale
They are currently set independently from the config, so sometimes they are way to small or way too large compared to max values in the config FPP. Users can't change them, so they are stuck with the values.
Testing/Review Recommendations
Re-run unit tests.
Future Work
None
AI Usage (see policy)
No usage