DpWriter shrink container buffer after processing#4904
Open
kubiak-jpl wants to merge 10 commits intonasa:develfrom
Open
DpWriter shrink container buffer after processing#4904kubiak-jpl wants to merge 10 commits intonasa:develfrom
kubiak-jpl wants to merge 10 commits intonasa:develfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
LeStarch
previously approved these changes
Mar 30, 2026
Collaborator
|
Looks ok to me, but I could really use @bocchino or @timcanham to review this. |
bocchino
reviewed
Mar 30, 2026
bocchino
reviewed
Apr 7, 2026
Svc/DpWriter/DpWriter.cpp
Outdated
| } | ||
| } | ||
|
|
||
| // Updated DpContainer object state with the returned value in the |
Collaborator
There was a problem hiding this comment.
Can we check whether there was any call to procBufferSendOut_out and update the DpContainer only if there was a call? That way if there's no processing, we don't have to recompute the state.
bocchino
reviewed
Apr 7, 2026
Collaborator
|
This PR is looking good! I just had two small comments on the revised code. |
Contributor
Author
|
@bocchino I pushed an update to address your two comments |
Collaborator
|
CI can be fixed by:
|
Contributor
Author
|
@thomas-bc Done |
bocchino
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Updates DpWriter to shrink and re-serialize the container header if a processing step shrinks the container buffer.
Rationale
Necessary to develop data product compression processing components.
Testing/Review Recommendations
Testing with an external deployment to compress camera images into a PNG
Added unit tests to test the new behavior
Future Work
None.
AI Usage (see policy)
N/A