Skip to content

Introduce optimized CRC-32 implementation #4917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
celskeggs wants to merge 3 commits into
base: devel
Choose a base branch
from

Reconcile with latest devel and fix CI

3f02b8f
Select commit
Loading
Failed to load commit list.
Open

Introduce optimized CRC-32 implementation #4917

Reconcile with latest devel and fix CI
3f02b8f
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Mar 31, 2026 in 2s

15 new alerts

New alerts in code changed by this pull request

  • 8 warnings
  • 7 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 24 in Svc/CmdSequencer/FPrimeSequence.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter bufferSize has not been checked.

Check warning on line 173 in Utils/Hash/Crc32/Crc32.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter length has not been checked.

Check warning on line 185 in Utils/Hash/Crc32/Crc32.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter crc has not been checked.

Check warning on line 199 in Utils/Hash/Crc32/Crc32.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter crc has not been checked.

Check warning on line 207 in Utils/Hash/Crc32/Crc32.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter crc has not been checked.

Check warning on line 209 in Utils/Hash/Crc32/Crc32.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter crc has not been checked.

Check warning on line 37 in Utils/Hash/Crc32/HashImpl.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter len has not been checked.

Check warning on line 62 in Utils/Hash/Crc32/HashImpl.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter value has not been checked.

Check notice on line 16 in Svc/CmdSequencer/FPrimeSequence.cpp

See this annotation in the file changed.

Code scanning / CodeQL

More than one statement per line Note

This line contains 2 statements; only one is allowed.

Check notice on line 172 in Utils/Hash/Crc32/Crc32.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 93 in Utils/Hash/libcrc/lib_crc.c

See this annotation in the file changed.

Code scanning / CodeQL

Conditional compilation Note

Use of conditional compilation must be kept to a minimum.

Check notice on line 102 in Utils/Hash/libcrc/lib_crc.c

See this annotation in the file changed.

Code scanning / CodeQL

Conditional compilation Note

Use of conditional compilation must be kept to a minimum.

Check notice on line 122 in Utils/Hash/libcrc/lib_crc.c

See this annotation in the file changed.

Code scanning / CodeQL

Conditional compilation Note

Use of conditional compilation must be kept to a minimum.

Check notice on line 282 in Utils/Hash/libcrc/lib_crc.c

See this annotation in the file changed.

Code scanning / CodeQL

Conditional compilation Note

Use of conditional compilation must be kept to a minimum.

Check notice on line 419 in Utils/Hash/libcrc/lib_crc.c

See this annotation in the file changed.

Code scanning / CodeQL

Conditional compilation Note

Use of conditional compilation must be kept to a minimum.