Fix CmdArgBuffer SERIALIZED_SIZE computation#4978
Open
Sarah5567 wants to merge 3 commits intonasa:develfrom
Open
Fix CmdArgBuffer SERIALIZED_SIZE computation#4978Sarah5567 wants to merge 3 commits intonasa:develfrom
Sarah5567 wants to merge 3 commits intonasa:develfrom
Conversation
Collaborator
|
To fix the formatting, you can run this command: git diff --name-only devel...HEAD | fprime-util format --stdin |
LeStarch
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Fix
CmdArgBuffer::SERIALIZED_SIZE, which incorrectly used sizeof(I32) instead of sizeof(FwSizeStoreType).To prevent this kind of mistake, this PR adds a STATIC_SERIALIZED_SIZE constexpr helper to LinearBufferBase and updates all buffer-derived classes to use it.
Rationale
If FwSizeStoreType is configured larger than I32 (e.g. U64),
CmdArgBuffer::SERIALIZED_SIZEwould be too small, potentially causing serialization issues.Testing/Review Recommendations
N/A
Future Work
N/A
AI Usage (see policy)
GitHub Copilot CLI (Claude)