Os::File::open Bounded Inputs#4980

Open

LeStarch wants to merge 17 commits intonasa:develfrom

JPL-Devin:devin/1775753537-os-file-open-overloads

Commits on Apr 9, 2026

Add Os::File::open overloads for bounded char* and Fw::StringBase

devin-ai-integration[bot]
and
LeStarch
committed
Fix off-by-one: use FW_FIXED_LENGTH_STRING_SIZE + 1 as buffer size bound

devin-ai-integration[bot]
and
LeStarch
committed
Address PR review: use ConstStringBase and FileNameStringSize

devin-ai-integration[bot]
and
LeStarch
committed
Add unit test rules for bounded char* and ConstStringBase open overloads

devin-ai-integration[bot]
and
LeStarch
committed
Add edge-case death test for unterminated path within bounds

devin-ai-integration[bot]
and
LeStarch
committed
Remove death test from randomized scenarios, keep as direct test only

devin-ai-integration[bot]
and
LeStarch
committed
Fix dangling m_path pointer in OpenFileCreateString test rule

devin-ai-integration[bot]
and
LeStarch
committed
Fix uniqueness loop condition to match OpenBaseRule pattern

devin-ai-integration[bot]
and
LeStarch
committed
Remove uniqueness loop from new open rules to prevent filename exhaustion

devin-ai-integration[bot]
and
LeStarch
committed
Restore uniqueness loop in new open rules to match OpenBaseRule pattern

devin-ai-integration[bot]
and
LeStarch
committed
Replace uniqueness loop with early-return for new open rules

devin-ai-integration[bot]
and
LeStarch
committed
Bump MAX_FILES and gracefully handle filename exhaustion in all open rules

devin-ai-integration[bot]
and
LeStarch
committed
Fix assert trip in unbounded open and improve assert diagnostics

devin-ai-integration[bot]
and
LeStarch
committed
Keep FileNameStringSize bound and cap test filenames to fit

devin-ai-integration[bot]
and
LeStarch
committed
Tighten filename cap: subtract 1 for safety margin

devin-ai-integration[bot]
and
LeStarch
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Os::File::open Bounded Inputs#4980

Os::File::open Bounded Inputs#4980
LeStarch wants to merge 17 commits intonasa:develfrom
JPL-Devin:devin/1775753537-os-file-open-overloads

Commits on Apr 9, 2026

Add Os::File::open overloads for bounded char* and Fw::StringBase

Fix off-by-one: use FW_FIXED_LENGTH_STRING_SIZE + 1 as buffer size bound

Address PR review: use ConstStringBase and FileNameStringSize

Add unit test rules for bounded char* and ConstStringBase open overloads

Add edge-case death test for unterminated path within bounds

Remove death test from randomized scenarios, keep as direct test only

Fix dangling m_path pointer in OpenFileCreateString test rule

Fix uniqueness loop condition to match OpenBaseRule pattern

Remove uniqueness loop from new open rules to prevent filename exhaustion

Restore uniqueness loop in new open rules to match OpenBaseRule pattern

Replace uniqueness loop with early-return for new open rules

Bump MAX_FILES and gracefully handle filename exhaustion in all open rules

Fix assert trip in unbounded open and improve assert diagnostics

Keep FileNameStringSize bound and cap test filenames to fit

Tighten filename cap: subtract 1 for safety margin

Commits on Apr 10, 2026

Bound test buffers by FileNameStringSize instead of _POSIX_PATH_MAX

Remove getFileSize check for too-long filename in ActiveTextLogger UT