Generalize uses of LinearBufferBase to SerialBufferBase where possible#4995
Open
odacindy-fprime wants to merge 4 commits intonasa:develfrom
Open
Generalize uses of LinearBufferBase to SerialBufferBase where possible#4995odacindy-fprime wants to merge 4 commits intonasa:develfrom
odacindy-fprime wants to merge 4 commits intonasa:develfrom
Conversation
…possible excluding ones that require changes to FPP code gen and excluding unit tests
thomas-bc
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| void AosFramer ::serialize_idle_spp_packet(Fw::LinearBufferBase& serializer, U16 length) { | ||
| void AosFramer ::serialize_idle_spp_packet(Fw::SerialBufferBase& serializer, U16 length) { |
| } | ||
|
|
||
| void TmFramer ::fill_with_idle_packet(Fw::LinearBufferBase& serializer) { | ||
| void TmFramer ::fill_with_idle_packet(Fw::SerialBufferBase& serializer) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Reduce ues of LinearBufferBase to SerialBufferBase where possible (excluding UTs and updates that would require updates to FPP)
Rationale
To use the more general SerialBufferBase vs the more restrictive LinearBufferBase when appropriate.
Testing/Review Recommendations
Re-ran existing unit tests
Future Work
In the original issue #4985, I documented in a comment, what updates could be made that would require a change to FPP, since this pull-request does NOT include any renames that would require a change to FPP.
AI Usage (see policy)
I used both Claude and Devin AI to help identify which changes should be made, along with rationale about why it chose to make those changes, and the ability to review changes step by step, and implementation of those changes upon review, and documentation for reference.