CI: stop using runner.debug in reusable project builder#4999
Draft
dcpagotto wants to merge 1 commit intonasa:develfrom
Draft
CI: stop using runner.debug in reusable project builder#4999dcpagotto wants to merge 1 commit intonasa:develfrom
dcpagotto wants to merge 1 commit intonasa:develfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes a workflow validation issue in the reusable project builder.
the current workflow sets VERBOSE_FLAG from an expression using runner.debug inside the env block. GitHub is rejecting that in the reusable workflow, which causes the ext-build workflows that call it to fail before they even start the actual build.
the fix here is to stop computing that flag in workflow expressions and instead set it inside each bash step from RUNNER_DEBUG. That keeps the same intent, but avoids the invalid workflow expression.
I checked the updated yaml locally to make sure it still parses cleanly, and this should unblock the external build workflows that were failing at workflow load time.
if there is a better repo-wide pattern for handling optional verbose flags in reusable workflows, I am happy to adjust, but this should be the safest direct fix for the current failure.
Thanks! Dhiego Pagotto...