Improve type safety in packages/config leaf modules#6909
Draft
Improve type safety in packages/config leaf modules#6909
Conversation
Converted several leaf modules in `packages/config` from JavaScript to TypeScript: - `src/utils/group.js` -> `src/utils/group.ts` - `src/utils/set.js` -> `src/utils/set.ts` - `src/utils/toml.js` -> `src/utils/toml.ts` - `src/origin.js` -> `src/origin.ts` Improved type safety in existing TypeScript modules: - `src/utils/remove_falsy.ts`: Added generic types to `removeFalsy`. - `src/error.ts`: Defined `CustomError` and `CustomErrorInfo` interfaces to avoid type assertions and `@ts-ignore`. - `src/parse.ts`: Improved type handling for error paths and return values. Added a type declaration for `tomlify-j0.4` in `src/types/tomlify-j0.4.d.ts`. Verified with full build and tests. No behavioral regressions introduced. Co-authored-by: serhalp <1377702+serhalp@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Converted several leaf modules in `packages/config` from JavaScript to TypeScript: - `src/utils/group.js` -> `src/utils/group.ts` - `src/utils/set.js` -> `src/utils/set.ts` - `src/utils/toml.js` -> `src/utils/toml.ts` - `src/origin.js` -> `src/origin.ts` Improved type safety in existing TypeScript modules: - `src/utils/remove_falsy.ts`: Added generic types to `removeFalsy`. - `src/error.ts`: Defined `CustomError` and `CustomErrorInfo` interfaces to avoid type assertions and `@ts-ignore`. - `src/parse.ts`: Improved type handling for error paths and return values. Added a type declaration for `tomlify-j0.4` in `src/types/tomlify-j0.4.d.ts`. Verified with full build and tests. No behavioral regressions introduced. Co-authored-by: serhalp <1377702+serhalp@users.noreply.github.com>
Converted several leaf modules in `packages/config` from JavaScript to TypeScript: - `src/utils/group.js` -> `src/utils/group.ts` - `src/utils/set.js` -> `src/utils/set.ts` - `src/utils/toml.js` -> `src/utils/toml.ts` - `src/origin.js` -> `src/origin.ts` Improved type safety in existing TypeScript modules: - `src/utils/remove_falsy.ts`: Added generic types to `removeFalsy`. - `src/error.ts`: Defined `CustomError` and `CustomErrorInfo` interfaces to avoid type assertions and `@ts-ignore`. - `src/parse.ts`: Improved type handling for error paths and return values. Added a type declaration for `tomlify-j0.4` in `src/types/tomlify-j0.4.d.ts`. Verified with full build and tests. No behavioral regressions introduced. addressed code review feedback regarding type quality and lockfile changes. Co-authored-by: serhalp <1377702+serhalp@users.noreply.github.com>
Converted leaf modules to TypeScript and improved type safety in existing TS files. - Converted `src/utils/group.js`, `src/utils/set.js`, `src/utils/toml.js`, and `src/origin.js` to `.ts`. - Improved types in `src/utils/remove_falsy.ts`, `src/error.ts`, and `src/parse.ts`. - Fixed a regression in `packages/build` error handling where missing `location` caused `TypeError`. - Removed unnecessary `@ts-ignore` and reduced `any` usage. Co-authored-by: serhalp <1377702+serhalp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted several leaf modules in
packages/configto TypeScript and improved type safety in existing modules without introducing behavioral changes or band-aids.PR created automatically by Jules for task 13847868642235084342 started by @serhalp