Skip to content

build: migrate to oxfmt #7016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheAlexLichter wants to merge 4 commits into
base: main
Choose a base branch
from
Open

build: migrate to oxfmt #7016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a693c0
build: migrate to oxfmt
TheAlexLichter Apr 1, 2026
e6ced83
yoink prettier related deps
TheAlexLichter Apr 1, 2026
81954cf
try adding oxfmt binding in CI
TheAlexLichter Apr 3, 2026
e2c62f8
Merge branch 'main' into build/oxfmt
TheAlexLichter Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ jobs:
steps:
- checkout
- npm-install-deps
# This is necessary to work around platform-specific optional dependencies bug
# (https://github.com/npm/cli/issues/4828).
- run: npm i -D @oxfmt/binding-linux-x64-gnu
Comment on lines +123 to +125
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify that oxfmt and its binding package exist on npm and check version alignment

echo "=== Checking oxfmt package ==="
curl -s https://registry.npmjs.org/oxfmt | jq '{name: .name, latest: .["dist-tags"].latest, versions: (.versions | keys | .[-5:])}'

echo ""
echo "=== Checking `@oxfmt/binding-linux-x64-gnu` package ==="
curl -s https://registry.npmjs.org/@oxfmt/binding-linux-x64-gnu | jq '{name: .name, latest: .["dist-tags"].latest, versions: (.versions | keys | .[-5:])}'

Repository: netlify/build

Length of output: 428

Pin the binding version to match oxfmt.

While @oxfmt/binding-linux-x64-gnu and oxfmt are currently both at version 0.43.0, pinning the binding version to @^0.43.0 ensures they stay in sync. Native bindings should explicitly declare version alignment with their parent packages to prevent future mismatches if versions diverge.

Proposed fix 
      # This is necessary to work around platform-specific optional dependencies bug
      # (https://github.com/npm/cli/issues/4828).
-      - run: npm i -D `@oxfmt/binding-linux-x64-gnu`
+      - run: npm i -D `@oxfmt/binding-linux-x64-gnu`@^0.43.0
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# This is necessary to work around platform-specific optional dependencies bug
# (https://github.com/npm/cli/issues/4828).
- run: npm i -D @oxfmt/binding-linux-x64-gnu
# This is necessary to work around platform-specific optional dependencies bug
# (https://github.com/npm/cli/issues/4828).
- run: npm i -D `@oxfmt/binding-linux-x64-gnu`@^0.43.0
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.circleci/config.yml around lines 123 - 125, Update the CircleCI job that
installs the native binding by pinning the binding package version to match
oxfmt: replace the bare package install of `@oxfmt/binding-linux-x64-gnu` used in
the run step with a versioned install (e.g.,
`@oxfmt/binding-linux-x64-gnu`@^0.43.0) so the native binding stays aligned with
oxfmt; locate the run step that currently contains "npm i -D
`@oxfmt/binding-linux-x64-gnu`" and change it to include the version specifier.

- run: npm run format:ci
- run: npm run build
- run: npm run lint:ci
2 changes: 1 addition & 1 deletion .github/.kodiak.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ versions = ["minor", "patch"]
usernames = ["renovate"]

[approve]
auto_approve_usernames = ["renovate"]
auto_approve_usernames = ["renovate"]
20 changes: 20 additions & 0 deletions .oxfmtrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"$schema": "./node_modules/oxfmt/configuration_schema.json",
"semi": false,
"singleQuote": true,
"printWidth": 120,
"proseWrap": "always",
"trailingComma": "all",
"sortPackageJson": false,
"ignorePatterns": [
"packages/*/tests/**/fixtures/**",
"packages/*/test/**/fixtures*/**",
"packages/*/benchmarks/**/fixtures*/**",
"packages/*/lib",
"packages/*/dist",
"packages/edge-bundler/deno/**",
"packages/edge-bundler/*/vendor/**",
"CHANGELOG.md",
"coverage"
]
}
14 changes: 0 additions & 14 deletions .prettierignore
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions .prettierrc.json
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { fileURLToPath } from 'node:url'
import { includeIgnoreFile } from '@eslint/compat'
import eslint from '@eslint/js'
import vitest from '@vitest/eslint-plugin'
import prettier from 'eslint-config-prettier'
import ava from 'eslint-plugin-ava'
import * as importPlugin from 'eslint-plugin-import'
import node from 'eslint-plugin-n'
Expand Down Expand Up @@ -135,7 +134,4 @@ export default tseslint.config(
},

temporarySuppressions,

// Must be last
prettier,
)
Loading
Loading