Skip to content

Only mask the permissions for the users home directory for public shares#59511

Merged
CarlSchwan merged 2 commits intomasterfrom
public-share-only-mask-home
Apr 9, 2026
Merged

Only mask the permissions for the users home directory for public shares#59511
CarlSchwan merged 2 commits intomasterfrom
public-share-only-mask-home

Conversation

@icewind1991
Copy link
Copy Markdown
Member

this ensures that versions/trashbin/etc is still usable.

DirPermissionsMask is copied from the guests app

Fixes #59354

@icewind1991 icewind1991 added this to the Nextcloud 34 milestone Apr 8, 2026
@icewind1991 icewind1991 requested a review from a team as a code owner April 8, 2026 16:03
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Apr 8, 2026
@icewind1991 icewind1991 requested review from ArtificialOwl, CarlSchwan, leftybournes and salmart-dev and removed request for a team April 8, 2026 16:03
@icewind1991 icewind1991 force-pushed the public-share-only-mask-home branch 2 times, most recently from 4cf7e05 to 3a73754 Compare April 8, 2026 16:32
@camilasan
Copy link
Copy Markdown
Member

/backport to stable-32.0

@camilasan
Copy link
Copy Markdown
Member

Backporting to stable 32 should be enough for what we need.

Copy link
Copy Markdown
Contributor

@cristianscheid cristianscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Signed-off-by: Robin Appelman <robin@icewind.nl>
…c shares

this ensures that versions/trashbin/etc is still usable

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the public-share-only-mask-home branch from 3a73754 to 3cd3c6d Compare April 9, 2026 14:19
@CarlSchwan CarlSchwan merged commit 14472cb into master Apr 9, 2026
224 of 237 checks passed
@CarlSchwan CarlSchwan deleted the public-share-only-mask-home branch April 9, 2026 23:54
@backportbot
Copy link
Copy Markdown

backportbot bot commented Apr 9, 2026

The backport to stable-32.0 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-32.0
git pull origin stable-32.0

# Create the new backport branch
git checkout -b backport/59511/stable-32.0

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e96a89e6 3cd3c6dd

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/59511/stable-32.0

Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/59511/stable-32.0')
fatal: not a valid object name: 'origin/stable-32.0'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@CarlSchwan
Copy link
Copy Markdown
Member

/backport to stable33

@CarlSchwan
Copy link
Copy Markdown
Member

/backport to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Editing a pdf from a public share does NOT create a new file version

4 participants