Skip to content

Fix: ensure stable column order in table view #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Koc wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

Fix: ensure stable column order in table view #2445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/store/data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ export const useDataStore = defineStore('data', {
if (!Array.isArray(res.data)) {
const e = new Error('Expected array, but is not')
displayError(e, 'Format for loaded columns not valid.')
return false
return []
}
} catch (e) {
displayError(e, t('tables', 'Could not load columns.'))
return false
return []
}

const columns = res.data.map(col => parseCol(col))
Expand All @@ -90,6 +90,8 @@ export const useDataStore = defineStore('data', {
return orderA - orderB
})
}
} else {
allColumns = allColumns.sort((a, b) => a.id - b.id)
}
const stateId = genStateKey(!!(view?.id), view?.id ?? tableId)
set(this.columns, stateId, allColumns)
Expand All @@ -108,10 +110,11 @@ export const useDataStore = defineStore('data', {
}
} catch (e) {
displayError(e, t('tables', 'Could not load columns.'))
return false
return []
}

const columns = res.data.ocs.data.map(col => parseCol(col))
.sort((a, b) => a.id - b.id)
// Fix up columns to match expected structure if needed
// Public API might return slightly different structure, but parseCol should handle it if it's standard TableColumn

Expand Down
Loading