Skip to content

Fix: reset default values for usergroup column after row creation #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Koc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: reset default values for usergroup column after row creation #2448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 14 additions & 24 deletions src/shared/components/ncTable/partials/rowTypePartials/UsergroupForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,23 +47,23 @@ export default {
return {
selectUsers: this.column.usergroupSelectUsers,
selectGroups: this.column.usergroupSelectGroups,
internalLocalValue: [],
}
},
computed: {
localValue: {
get() {
return this.internalLocalValue
let value = this.value
if (!value || (Array.isArray(value) && value.length === 0)) {
value = this.column.usergroupDefault || []
}
return (Array.isArray(value) ? value : []).map(item => ({
...(item ?? {}),
// Adding a unique key such that removing items works correctly
key: this.getKeyPrefix(item?.type) + (item?.id ?? ''),
}))
},
set(v) {
let formattedValue = null
if (Array.isArray(v)) {
formattedValue = v
} else {
formattedValue = [v]
}
this.internalLocalValue = formattedValue
this.$emit('update:value', formattedValue)
this.$emit('update:value', Array.isArray(v) ? v : [v])
},
},
},
Expand All @@ -73,20 +73,10 @@ export default {
// since the data() function runs before the capabilities are fully initialized
this.selectCircles = this.isCirclesEnabled ? this.column.usergroupSelectTeams : false

let initialValue = this.value
if (!initialValue || (Array.isArray(initialValue) && initialValue.length === 0)) {
initialValue = this.column.usergroupDefault || []
}

const formatted = (Array.isArray(initialValue) ? initialValue : []).map(item => ({
...(item ?? {}),
// Adding a unique key such that removing items works correctly
key: this.getKeyPrefix(item?.type) + (item?.id ?? ''),
}))
this.internalLocalValue = formatted

if (formatted.length > 0) {
this.$emit('update:value', formatted)
if (!this.value || (Array.isArray(this.value) && this.value.length === 0)) {
if (this.localValue.length > 0) {
this.$emit('update:value', this.localValue)
}
}
},
methods: {
Expand Down
Loading