Skip to content

inspector: fix compressed responses#62630

Open
legendecas wants to merge 2 commits intonodejs:mainfrom
legendecas:fix/inspector-compressed-responses
Open

inspector: fix compressed responses#62630
legendecas wants to merge 2 commits intonodejs:mainfrom
legendecas:fix/inspector-compressed-responses

Conversation

@legendecas
Copy link
Copy Markdown
Member

This relands #61226 with a fix on racing in http2 inspector when there is a decompressor.

rubnogueira and others added 2 commits April 7, 2026 16:41
PR-URL: nodejs#61226
Fixes: nodejs#61222
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/inspector

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Apr 8, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 98.88268% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (efa05f2) to head (cb4d3ef).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/inspector/network_http.js 98.48% 1 Missing ⚠️
lib/internal/inspector/network_http2.js 98.79% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62630      +/-   ##
==========================================
+ Coverage   89.77%   89.80%   +0.03%     
==========================================
  Files         697      697              
  Lines      215773   215914     +141     
  Branches    41304    41332      +28     
==========================================
+ Hits       193704   193896     +192     
+ Misses      14162    14116      -46     
+ Partials     7907     7902       -5     
Files with missing lines Coverage Δ
lib/internal/inspector/network.js 96.89% <100.00%> (+0.93%) ⬆️
lib/internal/inspector/network_http.js 95.93% <98.48%> (+0.66%) ⬆️
lib/internal/inspector/network_http2.js 89.78% <98.79%> (+2.04%) ⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +248 to +258
httpsServer.listen(0, async () => {
try {
await session.post('Network.enable');
await testNetworkInspection();
await session.post('Network.disable');
} catch (e) {
assert.fail(e);
} finally {
terminate();
}
});
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
httpsServer.listen(0, async () => {
try {
await session.post('Network.enable');
await testNetworkInspection();
await session.post('Network.disable');
} catch (e) {
assert.fail(e);
} finally {
terminate();
}
});
httpsServer.listen(0, () => (async () => {
try {
await session.post('Network.enable');
await testNetworkInspection();
await session.post('Network.disable');
} finally {
terminate();
}
})().then(common.mustCall()));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http2 Issues or PRs related to the http2 subsystem. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants