Closed
Conversation
…ent multiple instances that poll /session/validation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
===========================================
+ Coverage 36.82% 83.87% +47.04%
===========================================
Files 16 1 -15
Lines 410 31 -379
Branches 25 8 -17
===========================================
- Hits 151 26 -125
+ Misses 245 3 -242
+ Partials 14 2 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
messed up commits please see #355 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#3
This change does require a new major version!
❓ Type of change
📚 Description
Every running instance of Hanko does a session/validate ever so often.
When using useHanko on multiple plugins / middleware / pages, a lot of instances are polling.
We can prevent that by using
useStateHank elements are currenlty on v 2.3.
I've updated the package and places that have changed so the middleware works again