Skip to content

Fix attribute name typos, phantom type mismatches, and type tag typos#353

Merged
balat merged 2 commits intomasterfrom
typos-ai
Apr 3, 2026
Merged

Fix attribute name typos, phantom type mismatches, and type tag typos#353
balat merged 2 commits intomasterfrom
typos-ai

Conversation

@hhugo
Copy link
Copy Markdown
Member

@hhugo hhugo commented Feb 11, 2026

This is a large PR generated by claude AI assistant, that fixes many typos and copy-pasted errors

Output string fixes:

  • html_f.ml: a_reversed emitted "reserved" instead of "reversed"
  • html_f.ml: a_srclang emitted "xml:lang" instead of "srclang"
  • html_f.ml: string_of_sandbox_token emitted "allow-script" instead of "allow-scripts"
  • svg_f.ml: a_zoomAndPan emitted "zoomAndSpan" instead of "zoomAndPan"
  • svg_f.ml: a_requiredExtensions emitted "requiredExtension" (missing s)
  • svg_f.ml: a_externalRessourcesRequired emitted misspelled attribute name
  • svg_f.ml: a_edgeMode emitted "targetY" instead of "edgeMode"
  • svg_f.ml: a_filterRes emitted "filterResUnits" instead of "filterRes"
  • svg_f.ml: a_target emitted "xlink:target" instead of "target"
  • svg_f.ml: font_face_format emitted "font-face-uri" instead of "font-face-format"
  • svg_f.ml: a_glyph_name emitted "glyphname" instead of "glyph-name"
  • svg_f.ml: string_of_in_value used wrong case (sourceGraphic vs SourceGraphic)
  • svg_f.ml: `Align mapped to "" instead of "align"
  • svg_f.ml: colorimetric values used underscores instead of hyphens
  • svg_f.ml: string_of_dominant_baseline missing hyphens in 5 values

Phantom type fixes in svg_sigs.mli:

  • a_edgeMode, a_preserveAlpha returned `TargetY (copy-paste error)
  • a_filterRes returned FilterResUnits instead of FilterRes
  • a_target returned Xlink_target instead of Target
  • a_glyph_name returned glyphname instead of GlyphName
  • a_arabic_form returned Arabicform instead of ArabicForm
  • a_requiredExtensions returned `RequiredExtension (missing s)
  • a_xlink_title returned Title instead of Xlink_title
  • a_low returned High instead of Low in html_sigs.mli

Type tag typos:

  • svg_sigs.mli: Rendering_Indent -> Rendering_Intent
  • svg_sigs.mli: ZoomAndSpan -> ZoomAndPan
  • svg_sigs.mli: ExternalRessourcesRequired -> ExternalResourcesRequired
  • svg_types.mli: ZoomAndPlan -> ZoomAndPan
  • svg_types.mli: PreserveAspectRadio -> PreserveAspectRatio
  • svg_types.mli: fefuncg/fefuncb/fefuncr all incorrectly defined as `FeFuncA
  • svg_types.mli: Animate_Color -> AnimateColor in stop_content
  • svg_types.mli: ColorProfile -> Color_Profile in colorprofile
  • svg_types.mli: Missing_glyph -> MissingGlyph in container_element
  • svg_types.mli: glyphRef -> GlyphRef in altglyphitem_content
  • svg_types.mli: Bever -> Bevel in stroke-linejoin variant
  • html_types.mli: OneBeforeUnload -> OnBeforeUnload
  • html_types.mli: Autofcus -> Autofocus
  • html_types.mli: missing space between Map and Mark

Function name fixes:

  • svg_sigs.mli, svg_f.ml: a_baseFrenquency -> a_baseFrequency

Output string fixes:
- html_f.ml: a_reversed emitted "reserved" instead of "reversed"
- html_f.ml: a_srclang emitted "xml:lang" instead of "srclang"
- html_f.ml: string_of_sandbox_token emitted "allow-script" instead of "allow-scripts"
- svg_f.ml: a_zoomAndPan emitted "zoomAndSpan" instead of "zoomAndPan"
- svg_f.ml: a_requiredExtensions emitted "requiredExtension" (missing s)
- svg_f.ml: a_externalRessourcesRequired emitted misspelled attribute name
- svg_f.ml: a_edgeMode emitted "targetY" instead of "edgeMode"
- svg_f.ml: a_filterRes emitted "filterResUnits" instead of "filterRes"
- svg_f.ml: a_target emitted "xlink:target" instead of "target"
- svg_f.ml: font_face_format emitted "font-face-uri" instead of "font-face-format"
- svg_f.ml: a_glyph_name emitted "glyphname" instead of "glyph-name"
- svg_f.ml: string_of_in_value used wrong case (sourceGraphic vs SourceGraphic)
- svg_f.ml: `Align mapped to "" instead of "align"
- svg_f.ml: colorimetric values used underscores instead of hyphens
- svg_f.ml: string_of_dominant_baseline missing hyphens in 5 values

Phantom type fixes in svg_sigs.mli:
- a_edgeMode, a_preserveAlpha returned `TargetY (copy-paste error)
- a_filterRes returned `FilterResUnits instead of `FilterRes
- a_target returned `Xlink_target instead of `Target
- a_glyph_name returned `glyphname instead of `GlyphName
- a_arabic_form returned `Arabicform instead of `ArabicForm
- a_requiredExtensions returned `RequiredExtension (missing s)
- a_xlink_title returned `Title instead of `Xlink_title
- a_low returned `High instead of `Low in html_sigs.mli

Type tag typos:
- svg_sigs.mli: `Rendering_Indent -> `Rendering_Intent
- svg_sigs.mli: `ZoomAndSpan -> `ZoomAndPan
- svg_sigs.mli: `ExternalRessourcesRequired -> `ExternalResourcesRequired
- svg_types.mli: `ZoomAndPlan -> `ZoomAndPan
- svg_types.mli: `PreserveAspectRadio -> `PreserveAspectRatio
- svg_types.mli: fefuncg/fefuncb/fefuncr all incorrectly defined as `FeFuncA
- svg_types.mli: `Animate_Color -> `AnimateColor in stop_content
- svg_types.mli: `ColorProfile -> `Color_Profile in colorprofile
- svg_types.mli: `Missing_glyph -> `MissingGlyph in container_element
- svg_types.mli: `glyphRef -> `GlyphRef in altglyphitem_content
- svg_types.mli: `Bever -> `Bevel in stroke-linejoin variant
- html_types.mli: `OneBeforeUnload -> `OnBeforeUnload
- html_types.mli: `Autofcus -> `Autofocus
- html_types.mli: missing space between `Map and `Mark

Function name fixes:
- svg_sigs.mli, svg_f.ml: a_baseFrenquency -> a_baseFrequency

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@hhugo
Copy link
Copy Markdown
Member Author

hhugo commented Apr 2, 2026

@balat, do you want to take a look ?

@balat
Copy link
Copy Markdown
Member

balat commented Apr 2, 2026

Yes I will if @Drup is ok. Thanks for the ping.

@balat balat merged commit 0e6e2c5 into master Apr 3, 2026
0 of 16 checks passed
@balat
Copy link
Copy Markdown
Member

balat commented Apr 3, 2026

Thank you Hugo and Cloclo. This was a relevant use of AI. I fixed a typo and merged.

@hhugo hhugo deleted the typos-ai branch April 3, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants