Skip to content

Handle DateTime parsing with partial/missing data #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jschieck wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle DateTime parsing with partial/missing data #115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
404242f
safer datetime parsing
jschieck Oct 24, 2023
16cc4ac
better parse
jschieck Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions ExifLibrary/ExifBitConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,17 +65,26 @@ public static DateTime ToDateTime(byte[] data, bool hastime)
string[] parts = str.Split(new char[] { ':', ' ' });
try
{
if (hastime && parts.Length == 6)
if (hastime && parts.Length >= 6)
{
// yyyy:MM:dd HH:mm:ss
// This is the expected format though some cameras
// can use single digits. See Issue 21.
return new DateTime(int.Parse(parts[0]), int.Parse(parts[1]), int.Parse(parts[2]), int.Parse(parts[3]), int.Parse(parts[4]), int.Parse(parts[5]));
if (!int.TryParse(parts[0], out int year)) year = 1;
if (!int.TryParse(parts[1], out int month)) month = 1;
if (!int.TryParse(parts[2], out int day)) day = 1;
if (!int.TryParse(parts[3], out int hour)) hour = 0;
if (!int.TryParse(parts[4], out int minute)) minute = 0;
if (!int.TryParse(parts[5], out int second)) second = 0;
return new DateTime(year, month, day, hour, minute, second);
}
else if (!hastime && parts.Length == 3)
else if (!hastime && parts.Length >= 3)
{
// yyyy:MM:dd
return new DateTime(int.Parse(parts[0]), int.Parse(parts[1]), int.Parse(parts[2]));
if (!int.TryParse(parts[0], out int year)) year = 1;
if (!int.TryParse(parts[1], out int month)) month = 1;
if (!int.TryParse(parts[2], out int day)) day = 1;
return new DateTime(year, month, day);
}
else
{
Expand Down Expand Up @@ -456,4 +465,4 @@ public static byte[] GetBytes(double[] value, ByteOrder tobyteorder)
}
#endregion
}
}
}