Memory leak in parse_response usage of pydantic#3068
Open
avilaton wants to merge 1 commit intoopenai:mainfrom
Open
Memory leak in parse_response usage of pydantic#3068avilaton wants to merge 1 commit intoopenai:mainfrom
avilaton wants to merge 1 commit intoopenai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Address a memory leak in parse_response detected using the OpenAI client in a webserver context (gunicorn, gevent)
Additional context & links
Problem
client.responses.parse()can trigger sustained memory growth on pydantic >= 2.11 (see #1181).The issue is that
parse_response()used subscripted runtime generic aliases (for exampleParsedResponse[T]) when callingconstruct_type_unchecked(). In pydantic v2, this can cause repeated runtime generic specialization/schema work in a hot path.Fix
Use the non-subscripted runtime classes in
parse_response()when callingconstruct_type_unchecked():ParsedResponseOutputText[TextFormatT]→ParsedResponseOutputTextParsedResponseOutputMessage[TextFormatT]→ParsedResponseOutputMessageParsedResponse[TextFormatT]→ParsedResponseWhy this is safe
construct_type_unchecked()constructs models loosely and does not require runtime generic specialization for correctness here.parse_text()still produces the typedparsedpayload, and the return type for callers remainsParsedResponse[TextFormatT].Tests
tests/lib/responses/test_parsing.pythat fails ifparse_response()routes through_validate_non_model_type.OPENAI_RUN_MEMORY_TESTS=1) intests/lib/responses/test_parsing.py.