Skip to content

8381609: com/sun/jdi/EATests.java should not synchronize on an Integer instance #30560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plummercj wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −27
Open

8381609: com/sun/jdi/EATests.java should not synchronize on an Integer instance #30560

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51ac7ac
don't sync on an Integer
plummercj Apr 3, 2026
9f7d4dc
remove locking on Integer
plummercj Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 1 addition & 27 deletions test/jdk/com/sun/jdi/EATests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/*
* Copyright (c) 2026, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2020, 2025 SAP SE. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
Expand Down Expand Up @@ -259,7 +260,6 @@ public static void main(String[] args) {
new EAGetOwnedMonitorsTarget() .run();
new EAEntryCountTarget() .run();
new EARelockingObjectCurrentlyWaitingOnTarget() .run();
new EARelockingValueBasedTarget() .run();

// Test cases that require deoptimization even though neither
// locks nor allocations are eliminated at the point where
Expand Down Expand Up @@ -385,7 +385,6 @@ protected void runTests() throws Exception {
new EAGetOwnedMonitors() .run(this);
new EAEntryCount() .run(this);
new EARelockingObjectCurrentlyWaitingOn() .run(this);
new EARelockingValueBased() .run(this);

// Test cases that require deoptimization even though neither
// locks nor allocations are eliminated at the point where
Expand Down Expand Up @@ -2402,31 +2401,6 @@ public void dontinline_waitWhenWarmupDone(ForLocking l2) throws Exception {
}


/////////////////////////////////////////////////////////////////////////////

/**
* Test relocking eliminated @ValueBased object.
*/
class EARelockingValueBased extends EATestCaseBaseDebugger {

public void runTestCase() throws Exception {
BreakpointEvent bpe = resumeTo(TARGET_TESTCASE_BASE_NAME, "dontinline_brkpt", "()V");
printStack(bpe.thread());
@SuppressWarnings("unused")
ObjectReference o = getLocalRef(bpe.thread().frame(1), Integer.class.getName(), "l1");
}
}

class EARelockingValueBasedTarget extends EATestCaseBaseTarget {

public void dontinline_testMethod() {
Integer l1 = new Integer(255);
synchronized (l1) {
dontinline_brkpt();
}
}
}

/////////////////////////////////////////////////////////////////////////////
//
// Test cases that require deoptimization even though neither locks
Expand Down