Skip to content

8381997: Move markWord.hpp cleanups from the valhalla lworld branch#30667

Open
stefank wants to merge 2 commits intoopenjdk:masterfrom
stefank:8381997_mark_word_from_lworld
Open

8381997: Move markWord.hpp cleanups from the valhalla lworld branch#30667
stefank wants to merge 2 commits intoopenjdk:masterfrom
stefank:8381997_mark_word_from_lworld

Conversation

@stefank
Copy link
Copy Markdown
Member

@stefank stefank commented Apr 10, 2026

Valhalla adds new bits to the mark word and to support that we have tried to unify the structure of the comments and the constants to make it easier to get an overview of the mark word bits and how they are used.

I propose that we move over the restructuring part so that reviewing the Valhalla additions become easier.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8381997: Move markWord.hpp cleanups from the valhalla lworld branch (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30667/head:pull/30667
$ git checkout pull/30667

Update a local copy of the PR:
$ git checkout pull/30667
$ git pull https://git.openjdk.org/jdk.git pull/30667/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30667

View PR using the GUI difftool:
$ git pr show -t 30667

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30667.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 10, 2026

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 10, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Apr 10, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 10, 2026

@stefank The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 10, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 10, 2026

Webrevs

@Arraying
Copy link
Copy Markdown
Member

Do you also intend to upstream the wrong lock_mask [1] in the x86 C2 macro assembler? In this PR or a potential follow-up.

[1] https://github.com/openjdk/valhalla/pull/2310/changes#r3051318602

@stefank
Copy link
Copy Markdown
Member Author

stefank commented Apr 10, 2026

Do you also intend to upstream the wrong lock_mask [1] in the x86 C2 macro assembler? In this PR or a potential follow-up.

[1] https://github.com/openjdk/valhalla/pull/2310/changes#r3051318602

My intention was to do so in a follow-up, but maybe I should just sneak it in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants