8381997: Move markWord.hpp cleanups from the valhalla lworld branch#30667
8381997: Move markWord.hpp cleanups from the valhalla lworld branch#30667stefank wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back stefank! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Webrevs
|
|
Do you also intend to upstream the wrong [1] https://github.com/openjdk/valhalla/pull/2310/changes#r3051318602 |
My intention was to do so in a follow-up, but maybe I should just sneak it in here. |
Valhalla adds new bits to the mark word and to support that we have tried to unify the structure of the comments and the constants to make it easier to get an overview of the mark word bits and how they are used.
I propose that we move over the restructuring part so that reviewing the Valhalla additions become easier.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30667/head:pull/30667$ git checkout pull/30667Update a local copy of the PR:
$ git checkout pull/30667$ git pull https://git.openjdk.org/jdk.git pull/30667/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30667View PR using the GUI difftool:
$ git pr show -t 30667Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30667.diff
Using Webrev
Link to Webrev Comment