Skip to content

8380105: Test vmTestbase/nsk/jdi/ThreadReference/ownedMonitorsAndFrames/ownedMonitorsAndFrames003/ownedMonitorsAndFrames003.java failed#30676

Draft
toxaart wants to merge 1 commit intoopenjdk:masterfrom
toxaart:JDK-8380105-ownedMonitorsAndFrames003-failed-fixed
Draft

8380105: Test vmTestbase/nsk/jdi/ThreadReference/ownedMonitorsAndFrames/ownedMonitorsAndFrames003/ownedMonitorsAndFrames003.java failed#30676
toxaart wants to merge 1 commit intoopenjdk:masterfrom
toxaart:JDK-8380105-ownedMonitorsAndFrames003-failed-fixed

Conversation

@toxaart
Copy link
Copy Markdown
Contributor

@toxaart toxaart commented Apr 10, 2026

Hi, please consider the following changes:

this is a fix for a bug in the ObjectMonitor::wait() method introduced 8366659. This bug leads to increased failure rate of ownedMonitorsAndFrames003, though the test was very seldomly failing before 8366659. The fix just brings the failure rate back to where it used to be.

In short, 8366659 introduced a code path where there was no handling of a suspension request until the thread goes back to Java, which caused test failures slightly more often.

Now the extra condition is removed and a thread in TS_RUN state will get its suspension request handled at the right place.

Tested in tiers 1-7 plus extra stress tests.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8380105: Test vmTestbase/nsk/jdi/ThreadReference/ownedMonitorsAndFrames/ownedMonitorsAndFrames003/ownedMonitorsAndFrames003.java failed (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30676/head:pull/30676
$ git checkout pull/30676

Update a local copy of the PR:
$ git checkout pull/30676
$ git pull https://git.openjdk.org/jdk.git pull/30676/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30676

View PR using the GUI difftool:
$ git pr show -t 30676

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30676.diff

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 10, 2026

👋 Welcome back aartemov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 10, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 10, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 10, 2026

@toxaart The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant