8380105: Test vmTestbase/nsk/jdi/ThreadReference/ownedMonitorsAndFrames/ownedMonitorsAndFrames003/ownedMonitorsAndFrames003.java failed#30676
Draft
toxaart wants to merge 1 commit intoopenjdk:masterfrom
Conversation
…ng suspension request.
|
👋 Welcome back aartemov! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, please consider the following changes:
this is a fix for a bug in the
ObjectMonitor::wait()method introduced 8366659. This bug leads to increased failure rate ofownedMonitorsAndFrames003, though the test was very seldomly failing before 8366659. The fix just brings the failure rate back to where it used to be.In short, 8366659 introduced a code path where there was no handling of a suspension request until the thread goes back to Java, which caused test failures slightly more often.
Now the extra condition is removed and a thread in
TS_RUNstate will get its suspension request handled at the right place.Tested in tiers 1-7 plus extra stress tests.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30676/head:pull/30676$ git checkout pull/30676Update a local copy of the PR:
$ git checkout pull/30676$ git pull https://git.openjdk.org/jdk.git pull/30676/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30676View PR using the GUI difftool:
$ git pr show -t 30676Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30676.diff