Skip to content

8382042: Add drill-into and path info to ASN1Formatter#30685

Open
wangweij wants to merge 1 commit intoopenjdk:masterfrom
wangweij:8382042
Open

8382042: Add drill-into and path info to ASN1Formatter#30685
wangweij wants to merge 1 commit intoopenjdk:masterfrom
wangweij:8382042

Conversation

@wangweij
Copy link
Copy Markdown
Contributor

@wangweij wangweij commented Apr 10, 2026

This enhancement adds label display and allow drilling into an OCTET STRING or BIT STRING. The label can be used in other tools like DerUtil.

For example:

o $ echo 3009040730050201050500 | xxd -r -p > bin
# Before the change
o $ java ASN1Formatter.java bin
bin
0000: 30 09                                           ; SEQUENCE [9]
0002:       04 07 30 05 02 01 05 05 00                ;   OCTET STRING [7] <Unprintable>
# After the change
o $ java ASN1Formatter.java bin
0000: 30 09                                           ; []: SEQUENCE [9]
0002:       04 07 30 05 02 01 05 05 00                ; [0]: OCTET STRING [7] (try --drill=0)
o $ java ASN1Formatter.java bin --drill=0
0000: 30 09                                           ; []: SEQUENCE [9]
0002:       04 07                                     ; [0]: OCTET STRING [7]
0004:             30 05                               ; [0c]: SEQUENCE [5]
0006:                   02 01 05                      ; [0c0]: BYTE 5.
0009:                            05 00                ; [0c1]: NULL


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8382042: Add drill-into and path info to ASN1Formatter (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30685/head:pull/30685
$ git checkout pull/30685

Update a local copy of the PR:
$ git checkout pull/30685
$ git pull https://git.openjdk.org/jdk.git pull/30685/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30685

View PR using the GUI difftool:
$ git pr show -t 30685

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30685.diff

Using Webrev

Link to Webrev Comment

8382042: Add drill-into and path info to ASN1Formatter
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 10, 2026

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 10, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Apr 10, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 10, 2026

@wangweij The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 10, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 10, 2026

Webrevs

@wangweij
Copy link
Copy Markdown
Contributor Author

/label add security

@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 10, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 10, 2026

@wangweij
The security label was successfully added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant