8382042: Add drill-into and path info to ASN1Formatter#30685
Open
wangweij wants to merge 1 commit intoopenjdk:masterfrom
Open
8382042: Add drill-into and path info to ASN1Formatter#30685wangweij wants to merge 1 commit intoopenjdk:masterfrom
wangweij wants to merge 1 commit intoopenjdk:masterfrom
Conversation
8382042: Add drill-into and path info to ASN1Formatter
|
👋 Welcome back weijun! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Contributor
Author
|
/label add security |
|
@wangweij |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enhancement adds label display and allow drilling into an OCTET STRING or BIT STRING. The label can be used in other tools like
DerUtil.For example:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30685/head:pull/30685$ git checkout pull/30685Update a local copy of the PR:
$ git checkout pull/30685$ git pull https://git.openjdk.org/jdk.git pull/30685/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30685View PR using the GUI difftool:
$ git pr show -t 30685Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30685.diff
Using Webrev
Link to Webrev Comment