Skip to content

8380651: [ubsan] gc/logging/TestGCId.java triggers runtime error: division by zero in shenandoahAdaptiveHeuristics#30692

Open
kdnilsen wants to merge 2 commits intoopenjdk:masterfrom
kdnilsen:heuristic-divide-by-zero
Open

8380651: [ubsan] gc/logging/TestGCId.java triggers runtime error: division by zero in shenandoahAdaptiveHeuristics#30692
kdnilsen wants to merge 2 commits intoopenjdk:masterfrom
kdnilsen:heuristic-divide-by-zero

Conversation

@kdnilsen
Copy link
Copy Markdown
Contributor

@kdnilsen kdnilsen commented Apr 11, 2026

Test for divisor equal zero and behave differently when calculating slope of best-fit line to predict GC time.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8380651: [ubsan] gc/logging/TestGCId.java triggers runtime error: division by zero in shenandoahAdaptiveHeuristics (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30692/head:pull/30692
$ git checkout pull/30692

Update a local copy of the PR:
$ git checkout pull/30692
$ git pull https://git.openjdk.org/jdk.git pull/30692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30692

View PR using the GUI difftool:
$ git pr show -t 30692

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30692.diff

Using Webrev

Link to Webrev Comment

@kdnilsen
Copy link
Copy Markdown
Contributor Author

Passes Amazon CI pipline tests.

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 11, 2026

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 11, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Apr 11, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 11, 2026

@kdnilsen The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 11, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 11, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant