8382048: JFR: RecordingFile::write doesn't truncate when overwriting

[egahlin]

Could I have a review for a PR that truncates the file if it already exists? If the file isn’t truncated, leftovers from earlier may remain at the end of the file.

Testing: jdk/jdk/jfr

Thanks
Erik

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8382048: JFR: RecordingFile::write doesn't truncate when overwriting (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30693/head:pull/30693
$ git checkout pull/30693

Update a local copy of the PR:
$ git checkout pull/30693
$ git pull https://git.openjdk.org/jdk.git pull/30693/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30693

View PR using the GUI difftool:
$ git pr show -t 30693

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30693.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ed7cd897)