Skip to content

8380322: [lworld] Identity records use preview feature#2302

Open
vicente-romero-oracle wants to merge 5 commits intoopenjdk:lworldfrom
vicente-romero-oracle:JDK-8380322
Open

8380322: [lworld] Identity records use preview feature#2302
vicente-romero-oracle wants to merge 5 commits intoopenjdk:lworldfrom
vicente-romero-oracle:JDK-8380322

Conversation

@vicente-romero-oracle
Copy link
Copy Markdown
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Apr 6, 2026

Fields of identity records are generated with the ACC_STRICT_INIT flag but the class file corresponding to the record is not marked as using preview features. This bug is fixed in this PR,

TIA


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8380322: [lworld] Identity records use preview feature (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2302/head:pull/2302
$ git checkout pull/2302

Update a local copy of the PR:
$ git checkout pull/2302
$ git pull https://git.openjdk.org/valhalla.git pull/2302/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2302

View PR using the GUI difftool:
$ git pr show -t 2302

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2302.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 6, 2026

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8380322: [lworld] Identity records use preview feature

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld branch:

  • 3508b5a: 8381776: [lworld] cherry-pick JDK-8381475
  • 92c5e58: 8379695: [lworld] Update GCBasher to use value classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 6, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 6, 2026

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 6, 2026
@liach
Copy link
Copy Markdown
Member

liach commented Apr 8, 2026

We might have to desugar the FieldKey record in StrictProcessor...

@liach
Copy link
Copy Markdown
Member

liach commented Apr 8, 2026

Anyways, this looks buggy that a driver's main class can be compiled to be preview but jtreg is not running that driver with preview permissiveness. We should report to jtreg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants