8380322: [lworld] Identity records use preview feature#2302
8380322: [lworld] Identity records use preview feature#2302vicente-romero-oracle wants to merge 5 commits intoopenjdk:lworldfrom
Conversation
|
👋 Welcome back vromero! A progress list of the required criteria for merging this PR into |
|
@vicente-romero-oracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
We might have to desugar the |
|
Anyways, this looks buggy that a driver's main class can be compiled to be preview but jtreg is not running that driver with preview permissiveness. We should report to jtreg. |
Fields of identity records are generated with the ACC_STRICT_INIT flag but the class file corresponding to the record is not marked as using preview features. This bug is fixed in this PR,
TIA
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2302/head:pull/2302$ git checkout pull/2302Update a local copy of the PR:
$ git checkout pull/2302$ git pull https://git.openjdk.org/valhalla.git pull/2302/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2302View PR using the GUI difftool:
$ git pr show -t 2302Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2302.diff
Using Webrev
Link to Webrev Comment