Draft
Conversation
supakeen
force-pushed
the
split-yamls-for-fedora
branch
from
2af9755 to
40993d6
Compare
supakeen
force-pushed
the
split-yamls-for-fedora
branch
from
40993d6 to
05f37f9
Compare
LoadImageTypes searches for all relevant files in the folder and adds image type from each of those. Each image type can be defined only in one file.
Image config field in the image types yaml is common for all image types. It should be contained in the distro definitions. That way, image types can just contain a definition of different types rather than a common specific for all types.
Some data defined in imagetypes.yaml was not used at all, only defined as an anchor. Removing blocks to make imagetypes yaml more simple.
The default_kernel_options was not used for fedora, and there was also a typo. Removing it.
Adds a logic for prepending a file _common.yaml in front of other yaml image types which allows splitting yaml files while keeping common anchors.
We can't have duplicate keys in YAML files so with prepending of `_common.yaml` we need a second arbitrary top-level key. Perhaps we should just turn off being strict about what keys are allowed at the top level? :) Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
Split off the 'common' bits and the image types into two separate files. Initially called `uncategorized`. Next commits will start splitting off per-variant. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
An initial naive split of the YAML definitions; they are mostly split along variant lines though some bits aren't quite right yet; those will be addressed in clean-up commits after this one. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
Split out things from `_common.yaml` that are only relevant to a specific variant (which now lives in its own file). Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
avitova
force-pushed
the
split-yamls-for-fedora
branch
from
05f37f9 to
6543e90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT BASED ON #2257
Work in progress.