network-installer: Do not set timezone or locale in Kickstart#2295
Open
brlane-rht wants to merge 1 commit intoosbuild:mainfrom
Open
network-installer: Do not set timezone or locale in Kickstart#2295brlane-rht wants to merge 1 commit intoosbuild:mainfrom
brlane-rht wants to merge 1 commit intoosbuild:mainfrom
Conversation
brlane-rht
force-pushed
the
main-empty-kickstart
branch
from
e35dde1 to
6f9307f
Compare
brlane-rht
force-pushed
the
main-empty-kickstart
branch
from
6f9307f to
1cef05d
Compare
The network installer does not use these values to create a kickstart. The blueprint Locale is used for the locale of the booted iso, not the installed system. The timezone customization is not used at all. But setting these triggers creation of an empty osbuild.ks which causes Anaconda to crash. This removes the code that was setting these in the Kickstart struct. Locale is still set in the installer using org.osbuild.locale This includes new manifest tests that only set customizations.locale in the blueprint which will create an org.osbuild.locale stage, but NOT an org.osbuild.kickstart stage. Resolves: HMS-10469
brlane-rht
force-pushed
the
main-empty-kickstart
branch
from
1cef05d to
773ffe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The network installer does not use these values to create a kickstart. The blueprint Locale is used for the locale of the booted iso, not the installed system. The timezone customization is not used at all. But setting these triggers creation of an empty osbuild.ks which causes Anaconda to crash.
Remove both of them, and remove locale from the list of supported blueprint options in the image definitions yaml.
Related: HMS-10469