Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/js/phoenix_live_view/view.js
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ export default class View {
!fromEl.isEqualNode(toEl) &&
!(isIgnored && isEqualObj(fromEl.dataset, toEl.dataset))
) {
hook.__beforeUpdate();
hook.__beforeUpdate(fromEl, toEl);
return hook;
}
}
Expand Down
10 changes: 5 additions & 5 deletions assets/js/phoenix_live_view/view_hook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export interface HookInterface<E extends HTMLElement = HTMLElement> {
* Called when the element is about to be updated in the DOM.
* Note: any call here must be synchronous as the operation cannot be deferred or cancelled.
*/
beforeUpdate?: () => void;
beforeUpdate?: (fromEl: E, toEl: E) => void;

/**
* The updated callback.
Expand Down Expand Up @@ -173,7 +173,7 @@ export interface Hook<T = object, E extends HTMLElement = HTMLElement> {
* Called when the element is about to be updated in the DOM.
* Note: any call here must be synchronous as the operation cannot be deferred or cancelled.
*/
beforeUpdate?: (this: T & HookInterface<E>) => void;
beforeUpdate?: (this: T & HookInterface<E>, fromEl: E, toEl: E) => void;

/**
* The updated callback.
Expand Down Expand Up @@ -347,7 +347,7 @@ export class ViewHook<E extends HTMLElement = HTMLElement>

// Default lifecycle methods
mounted(): void {}
beforeUpdate(): void {}
beforeUpdate(_fromEl: E, _toEl: E): void {}
updated(): void {}
destroyed(): void {}
disconnected(): void {}
Expand All @@ -364,8 +364,8 @@ export class ViewHook<E extends HTMLElement = HTMLElement>
this.updated();
}
/** @internal */
__beforeUpdate() {
this.beforeUpdate();
__beforeUpdate(fromEl, toEl) {
this.beforeUpdate(fromEl, toEl);
}
/** @internal */
__destroyed() {
Expand Down
Loading