Add args fromEl & toEl on beforeUpdate hook#4034
Closed
suciptoid wants to merge 3 commits intophoenixframework:mainfrom
Closed
Add args fromEl & toEl on beforeUpdate hook#4034suciptoid wants to merge 3 commits intophoenixframework:mainfrom
suciptoid wants to merge 3 commits intophoenixframework:mainfrom
Conversation
Collaborator
|
Duplicate of #3616, but it's good to have a test included! |
Author
|
My bad for searching the existing PR in the wrong repo (phoenixframework/phoenix). Thanks for pointing it out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for a
beforeUpdate(fromEl, toEl)function on client hooks, allowing hooks to handle DOM update logic similarly to the global LiveSocket optiondom.onBeforeElUpdated(from, to).Until now, intercepting DOM updates before patching was only possible through the global dom.onBeforeElUpdated callback. This PR extends that behavior to hooks, allowing them to handle pre-update logic locally during LiveView DOM diffs.