Add MacroComponent directives and Root Tag Attribute functionality#4127
Add MacroComponent directives and Root Tag Attribute functionality#4127
Conversation
SteffenDE
force-pushed
the
sd-macro-component-directives
branch
3 times, most recently
from
4d8320d to
2524b4c
Compare
|
@SteffenDE You are awesome!! Thank you for all your hard work on this feature this week! I will take a pass through this PR this evening and work on porting the ColocatedCSS work based on this functionality this weekend :) |
SteffenDE
force-pushed
the
sd-macro-component-directives
branch
from
2524b4c to
5509234
Compare
green-david
left a comment
green-david
left a comment
There was a problem hiding this comment.
This looks great overall - I left some comments, primarily things referencing the old root_tag_annotation initial pass at things 👍
|
|
||
| Expected global :root_tag_attribute to be a string, got: #{inspect(configured_attribute)} | ||
|
|
||
| The global :root_tag_attribute is typically used for `Phoenix.LiveView.ColocatedCSS` and |
There was a problem hiding this comment.
I wonder if for this PR we should leave out mention of ColocatedCSS and just have this say The global :root_tag_attribute is usually configured to "phx-r" and then in the PR adding ColocatedCSS I can update the message to include stuff about ColocatedCSS?
There was a problem hiding this comment.
I think this is fine, since we're planning to add it as the next step anyway (and we don't plan to do a release with those changes, so there's enough time to iron it out if needed later on)
SteffenDE
force-pushed
the
sd-macro-component-directives
branch
from
5509234 to
05a466f
Compare
Supersedes #4116. Co-Authored-By: David Green <134172184+green-david@users.noreply.github.com>
Co-Authored-By: David Green <134172184+green-david@users.noreply.github.com>
Co-authored-by: David Green <134172184+green-david@users.noreply.github.com>
Co-authored-by: David Green <134172184+green-david@users.noreply.github.com>
Co-Authored-By: David Green <134172184+green-david@users.noreply.github.com>
SteffenDE
force-pushed
the
sd-macro-component-directives
branch
from
7b98f44 to
2833181
Compare
|
@green-david thank you for reviewing, I addressed most of the comments! I forgot to rebase yesterday after merging, so the PR contained all of the commits from #4125 as well - sorry about that. |
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
I added some comments but they are not blockers, as they can be moved around after the fact.
3 participants
Supersedes #4116.