Fix docs: correct push_event behavior on redirect#4183
Open
preciz wants to merge 1 commit intophoenixframework:mainfrom
Open
Fix docs: correct push_event behavior on redirect#4183preciz wants to merge 1 commit intophoenixframework:mainfrom
preciz wants to merge 1 commit intophoenixframework:mainfrom
Conversation
Update the documentation for push_event/3 to correctly reflect that events pushed during a redirect (such as push_navigate/2) are sent to the client before the redirection happens, rather than being discarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the docs for
push_event/3to reflect that events pushed during a redirect (such aspush_navigate/2) are sent to the client before the redirection happens, rather than being discarded.History:
c01e90b
cb7db8b
968bd54
Test showing events sent during redirect:
test/phoenix_live_view/integrations/event_test.exs:55