Add custom upload validator to allow_upload/3 options#4189
Open
arthurnovak wants to merge 2 commits intophoenixframework:mainfrom
Open
Add custom upload validator to allow_upload/3 options#4189arthurnovak wants to merge 2 commits intophoenixframework:mainfrom
arthurnovak wants to merge 2 commits intophoenixframework:mainfrom
Conversation
Contributor
|
This would be very useful. I’ve recently jumped through some hoops to validate that uploaded images are square cropped for example. |
Author
|
hey @preciz @SteffenDE, any chance you can have a look at it? |
Contributor
|
I can but I'm not a maintainer, so let's wait for them as usual. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
allow_upload/3supports validation only for entry size and accepted file types via the:max_file_sizeand:acceptoptions. It would be useful to allow custom validation logic to run against each upload entry and return tailored errors when validation fails.This change introduces support for custom upload validation by adding a
:validatoroption toallow_upload/3.The validator is a user-defined function that is executed for each upload entry and can return custom error reasons when validation does not pass.
@preciz @SteffenDE