Skip to content

fix: close-pr count included unsuccessful runs #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghinks wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: close-pr count included unsuccessful runs #113

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b4b086
fix: close-pr count included unsuccessful runs
ghinks Dec 29, 2021
1d8146d
fix: array sz zero handling
ghinks Dec 31, 2021
e7bdc2a
fix: array sz zero handling
ghinks Jan 5, 2022
798292d
fix: grammar
ghinks Jan 15, 2022
ea96251
fix: grammar
ghinks Jan 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/closePR.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module.exports = async ({ dependents }) => {
const branch = await context.getTestingBranchName(parentBranchName)
const resp = await github.getChecks(dependentPkgInfo.owner, dependentPkgInfo.name, branch)
const closedPR = await closeDependencyPR(dependentPkgInfo.owner, dependentPkgInfo.name, branch, resp.data.check_runs)
if (closedPR) {
if (closedPR && closedPR.length > 0) {
Copy link
Copy Markdown
Member

@ljharb ljharb Dec 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case, is it ever not an array?

Suggested change
if (closedPR && closedPR.length > 0) {
if (closedPR.length > 0) {

Copy link
Copy Markdown
Contributor Author

@ghinks ghinks Dec 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that is true

Copy link
Copy Markdown
Member

@dominykas dominykas Jan 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the tests are now failing?

I haven't checked if this is a mocked response...

closedPrs.push(closedPR)
Copy link
Copy Markdown
Member

@ljharb ljharb Dec 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it'd be better to always push it unconditionally, and make the "count" code smarter?

Copy link
Copy Markdown
Contributor Author

@ghinks ghinks Dec 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart counting is in the TODOs, this is just a tidy up from the first draft update of the readme. But its good to find things when documenting.

}
}
Expand Down