fix: preserve layerPlacementsDirty flag when octree placements are removed#8584
Merged
mvaligursky merged 1 commit intomainfrom Apr 9, 2026
Merged
fix: preserve layerPlacementsDirty flag when octree placements are removed#8584mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
…moved In reconcile(), the non-octree dirtiness check unconditionally overwrote layerPlacementsDirty with `=`, discarding the `true` set by octree placement removal. This prevented updateWorldState() from detecting the change, leaving stale splats visible until camera movement triggered a rebuild via an unrelated path. Changed `=` to `||=` to preserve the flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where disabling a GSplat entity with an octree resource (e.g. LOD-streamed splats) didn't immediately remove it from rendering until the camera moved.
Changes:
GSplatManager.reconcile(), changed=to||=when computing non-octree placement dirtiness, so the dirty flag set by octree placement removal is preservedThe root cause: when an octree placement was removed,
layerPlacementsDirtywas correctly set totrue. However, the subsequent non-octree dirtiness comparison unconditionally overwrote it back tofalse(since non-octree placements hadn't changed). This preventedupdateWorldState()from creating a new world state, leaving stale splats visible until an unrelated camera movement triggered a rebuild through a different code path.