deleted-libraries.py: fix exception handling and miss-counting#169
Open
equinox0815 wants to merge 1 commit intoprometheus-community:masterfrom
Open
deleted-libraries.py: fix exception handling and miss-counting#169equinox0815 wants to merge 1 commit intoprometheus-community:masterfrom
equinox0815 wants to merge 1 commit intoprometheus-community:masterfrom
Conversation
EnvironmentError exceptions deprecated since Python 3.3 and are now longer used. I have this changes running since over a year now and have never encountered any other exceptions than FileNotFoundError or ProcessLookupError. Also due to an indentation error the metric values could never reach anything above 1 even if the outdated library is used more than once. Signed-off-by: Christian Pointner <equinox@spreadspace.org>
equinox0815
force-pushed
the
topic/fix-deleted-libs
branch
from
a31d7c2 to
0a0a0d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnvironmentError exceptions deprecated since Python 3.3 and are now longer used. I have this changes running since over a year now and have never encountered any other exceptions than FileNotFoundError or ProcessLookupError.
Also due to an indentation error the metric values could never reach anything above 1 even if the outdated library is used more than once.