fix(interpreter): verify py launcher path exists before returning#1728
Draft
BillionClaw wants to merge 1 commit intopypa:mainfrom
Draft
fix(interpreter): verify py launcher path exists before returning#1728BillionClaw wants to merge 1 commit intopypa:mainfrom
BillionClaw wants to merge 1 commit intopypa:mainfrom
Conversation
The Windows py launcher can return stale registry entries for uninstalled Python versions. Added a check to verify the returned path actually exists before using it. Fixes pypa#1723
Member
|
Please fix this error: |
cclauss
reviewed
Mar 17, 2026
| InterpreterResolutionError, | ||
| _find_default_windows_python, | ||
| _get_absolute_python_interpreter, | ||
| find_python_interpreter, |
Contributor
There was a problem hiding this comment.
Put that find_py_launcher_python import here to placate the linter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows
pylauncher can return stale registry entries for Python versions that have been uninstalled or moved. This causes pipx to fail with "did not find executable at path" errors when trying to use the returned path.Added a check to verify the path returned by the py launcher actually exists on disk before returning it from
find_py_launcher_python().Fixes #1723