fix: clearer error message when pip subprocess crashes#1739
Draft
BillionClaw wants to merge 1 commit intopypa:mainfrom
Draft
fix: clearer error message when pip subprocess crashes#1739BillionClaw wants to merge 1 commit intopypa:mainfrom
BillionClaw wants to merge 1 commit intopypa:mainfrom
Conversation
When pip crashes during 'pip list' execution (e.g., due to a misconfigured Python environment), the subprocess returns an empty stdout. Previously, this caused a misleading JSONDecodeError when trying to parse the empty string. Now we explicitly check the subprocess return code and raise a clear error message indicating that pip failed. Fixes pypa#1698
gaborbernat
requested changes
Mar 18, 2026
Contributor
gaborbernat
left a comment
gaborbernat
left a comment
There was a problem hiding this comment.
Please addd a test for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves error messaging when the pip subprocess crashes, making it clear that pip failed rather than showing a misleading exception.
When pip crashes during 'pip list' execution (e.g., due to a misconfigured Python environment), the subprocess returns an empty stdout. Previously, this caused a misleading JSONDecodeError when trying to parse the empty string. Now we explicitly check the subprocess return code and raise a clear error message indicating that pip failed.
Fixes #1698.