fix(standalone_python): extract hash from sha256: prefix in digest field#1775
Draft
BillionClaw wants to merge 2 commits intopypa:mainfrom
Draft
fix(standalone_python): extract hash from sha256: prefix in digest field#1775BillionClaw wants to merge 2 commits intopypa:mainfrom
BillionClaw wants to merge 2 commits intopypa:mainfrom
Conversation
The GitHub API's asset digest field returns values in the format
"sha256:HASH", but the unpacking code expected just the hash string.
This caused a "ValueError: too many values to unpack" when iterating
over python_releases.
Fix by using .partition(":")[2] to extract just the hash portion.
Fixes pypa#1774.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
ValueError: too many values to unpackthat occurred when using--fetch-missing-python.Root Cause
The GitHub API's
asset["digest"]field returns values in the format"sha256:HASH"(a single string), butget_latest_python_releases()stored this directly as the second tuple element. Whenlist_pythons()later iterated and unpackedfor link, digest in python_releases, it expected two separate values but got a single string containing a colon, causing the error.Fix
Extract just the hash portion using
.partition(":")[2]:This is safe because the GitHub API digest format is always
"sha256:HASH"with exactly one colon.Testing
Fixes #1774