Skip to content

fix: run flash operations on background thread to avoid UI message pump dependency #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akash1306 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: run flash operations on background thread to avoid UI message pump dependency #501

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e4acce
fix: run flash operations on background thread to avoid UI message pu…
akash1306 Apr 1, 2026
38b86f5
Added Tasks import
akash1306 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 45 additions & 29 deletions windows/QMK Toolbox/MainWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,19 +293,23 @@

if (!windowState.AutoFlashEnabled)
{
Invoke(new Action(DisableUI));
DisableUI();
}

foreach (BootloaderDevice b in FindBootloaders())
var bootloaders = FindBootloaders();
await Task.Run(async () =>

Check failure on line 300 in windows/QMK Toolbox/MainWindow.cs

View workflow job for this annotation

GitHub Actions / Build (Windows) 

The name 'Task' does not exist in the current context
{
logTextBox.LogBootloader("Attempting to flash, please don't remove device");
await b.Flash(selectedMcu, filePath);
logTextBox.LogBootloader("Flash complete");
}
foreach (BootloaderDevice b in bootloaders)
{
Invoke(new Action(() => logTextBox.LogBootloader("Attempting to flash, please don't remove device")));
await b.Flash(selectedMcu, filePath);
Invoke(new Action(() => logTextBox.LogBootloader("Flash complete")));
}
});

if (!windowState.AutoFlashEnabled)
{
Invoke(new Action(EnableUI));
EnableUI();
}
}

Expand All @@ -315,20 +319,24 @@

if (!windowState.AutoFlashEnabled)
{
Invoke(new Action(DisableUI));
DisableUI();
}

foreach (BootloaderDevice b in FindBootloaders())
var bootloaders = FindBootloaders();
await Task.Run(async () =>

Check failure on line 326 in windows/QMK Toolbox/MainWindow.cs

View workflow job for this annotation

GitHub Actions / Build (Windows) 

The name 'Task' does not exist in the current context
{
if (b.IsResettable)
foreach (BootloaderDevice b in bootloaders)
{
await b.Reset(selectedMcu);
if (b.IsResettable)
{
await b.Reset(selectedMcu);
}
}
}
});

if (!windowState.AutoFlashEnabled)
{
Invoke(new Action(EnableUI));
EnableUI();
}
}

Expand All @@ -338,22 +346,26 @@

if (!windowState.AutoFlashEnabled)
{
Invoke(new Action(DisableUI));
DisableUI();
}

foreach (BootloaderDevice b in FindBootloaders())
var bootloaders = FindBootloaders();
await Task.Run(async () =>

Check failure on line 353 in windows/QMK Toolbox/MainWindow.cs

View workflow job for this annotation

GitHub Actions / Build (Windows) 

The name 'Task' does not exist in the current context
{
if (b.IsEepromFlashable)
foreach (BootloaderDevice b in bootloaders)
{
logTextBox.LogBootloader("Attempting to clear EEPROM, please don't remove device");
await b.FlashEeprom(selectedMcu, "reset.eep");
logTextBox.LogBootloader("EEPROM clear complete");
if (b.IsEepromFlashable)
{
Invoke(new Action(() => logTextBox.LogBootloader("Attempting to clear EEPROM, please don't remove device")));
await b.FlashEeprom(selectedMcu, "reset.eep");
Invoke(new Action(() => logTextBox.LogBootloader("EEPROM clear complete")));
}
}
}
});

if (!windowState.AutoFlashEnabled)
{
Invoke(new Action(EnableUI));
EnableUI();
}
}

Expand All @@ -364,22 +376,26 @@

if (!windowState.AutoFlashEnabled)
{
Invoke(new Action(DisableUI));
DisableUI();
}

foreach (BootloaderDevice b in FindBootloaders())
var bootloaders = FindBootloaders();
await Task.Run(async () =>

Check failure on line 383 in windows/QMK Toolbox/MainWindow.cs

View workflow job for this annotation

GitHub Actions / Build (Windows) 

The name 'Task' does not exist in the current context
{
if (b.IsEepromFlashable)
foreach (BootloaderDevice b in bootloaders)
{
logTextBox.LogBootloader("Attempting to set handedness, please don't remove device");
await b.FlashEeprom(selectedMcu, file);
logTextBox.LogBootloader("EEPROM write complete");
if (b.IsEepromFlashable)
{
Invoke(new Action(() => logTextBox.LogBootloader("Attempting to set handedness, please don't remove device")));
await b.FlashEeprom(selectedMcu, file);
Invoke(new Action(() => logTextBox.LogBootloader("EEPROM write complete")));
}
}
}
});

if (!windowState.AutoFlashEnabled)
{
Invoke(new Action(EnableUI));
EnableUI();
}
}

Expand Down
Loading