-
Notifications
You must be signed in to change notification settings - Fork 450
chore(deps-dev): bump vite from 5.4.21 to 6.4.2 #5753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -232,7 +232,7 @@ | |
| "tsconfig-paths-webpack-plugin": "^4.1.0", | ||
| "typescript": "^4.0.5", | ||
| "url-loader": "^4.1.0", | ||
| "vite": "^5.4.21", | ||
| "vite": "^6.4.2", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Plugin-react version incompatible with Vite 6 peer dependencyMedium Severity Bumping Reviewed by Cursor Bugbot for commit 99eac41. Configure here. |
||
| "vite-bundle-visualizer": "1.0.1", | ||
| "vite-plugin-compression2": "^1.1.0", | ||
| "vite-plugin-ejs": "^1.7.0", | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sass API default silently changed from legacy to modern
High Severity
Bumping Vite from 5 to 6 changes the default
css.preprocessorOptions.scss.apifrom'legacy'to'modern-compiler'(becausesass-embeddedis installed). The vite configs atredisinsight/ui/vite.config.mjsand.storybook/vite.config.tsdon't explicitly set anapivalue, so they'll silently pick up the new default. The project extensively uses@importin its SCSS files (e.g.,main.scss,_components.scss, and markdown styles), which behaves differently under the modern compiler API and may produce deprecation warnings or compilation errors. This is a documented breaking change in the Vite 5→6 migration guide.Reviewed by Cursor Bugbot for commit 99eac41. Configure here.