Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@
"tsconfig-paths-webpack-plugin": "^4.1.0",
"typescript": "^4.0.5",
"url-loader": "^4.1.0",
"vite": "^5.4.21",
"vite": "^6.4.2",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sass API default silently changed from legacy to modern

High Severity

Bumping Vite from 5 to 6 changes the default css.preprocessorOptions.scss.api from 'legacy' to 'modern-compiler' (because sass-embedded is installed). The vite configs at redisinsight/ui/vite.config.mjs and .storybook/vite.config.ts don't explicitly set an api value, so they'll silently pick up the new default. The project extensively uses @import in its SCSS files (e.g., main.scss, _components.scss, and markdown styles), which behaves differently under the modern compiler API and may produce deprecation warnings or compilation errors. This is a documented breaking change in the Vite 5→6 migration guide.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 99eac41. Configure here.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin-react version incompatible with Vite 6 peer dependency

Medium Severity

Bumping vite to ^6.4.2 creates a peer dependency mismatch with the locked @vitejs/plugin-react@4.2.1, which declares "vite": "^4.2.0 || ^5.0.0" — excluding Vite 6. Vite 6 support was added in @vitejs/plugin-react@4.3.4. The yarn.lock still pins 4.2.1, so this plugin isn't automatically upgraded. While it may work in practice, it's not officially supported and risks subtle build issues.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 99eac41. Configure here.

"vite-bundle-visualizer": "1.0.1",
"vite-plugin-compression2": "^1.1.0",
"vite-plugin-ejs": "^1.7.0",
Expand Down
Loading
Loading