#5776 Fix Docker build failure due to sass-embedded dart binary on Alpine#5778
Open
valkirilov wants to merge 2 commits intomainfrom
Open
#5776 Fix Docker build failure due to sass-embedded dart binary on Alpine#5778valkirilov wants to merge 2 commits intomainfrom
valkirilov wants to merge 2 commits intomainfrom
Conversation
The sass-embedded package bundles a Dart VM binary compiled for glibc, which fails on Alpine Linux (musl libc). Adding gcompat provides the glibc compatibility layer needed for the Dart runtime to execute. Also fixes the Dockerfile `as` -> `AS` casing warning. Fixes #5776 Made-with: Cursor
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
Contributor
Code Coverage - Backend unit tests
Test suite run success3339 tests passing in 305 suites. Report generated by 🧪jest coverage report action from b351af7 |
Contributor
Code Coverage - Integration Tests
|
Contributor
Code Coverage - Frontend unit tests
Test suite run success6638 tests passing in 780 suites. Report generated by 🧪jest coverage report action from b351af7 |
Adds a reusable workflow that builds the root Dockerfile to catch build-time failures early. Runs alongside lint in the test pipeline. Fixes #5776 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added
gcompatto the Alpine build stage to provide glibc compatibility for thesass-embeddedDart VM binary. Thesassdependency is aliased tosass-embedded, which bundles a Dart runtime compiled for glibc. Since Alpine uses musl libc, the build fails atyarn build:staticswhen thesassCLI is invoked.Also fixed the
FROM ... as->FROM ... AScasing warning.Testing
Built the Docker image locally and confirmed:
yarn build:staticscompletes successfully (sass compiles plugin SCSS files)Fixes #5776
Made with Cursor
Note
Low Risk
Low risk: changes are limited to Docker build dependencies and CI workflows, but could affect build reproducibility/size and fail if
gcompatavailability changes on Alpine.Overview
Fixes Alpine Docker image build failures by adding
gcompatto the build-stageapk addlist so thesass-embedded(glibc-linked) binary can run duringyarn build:statics, and adjustsFROM ... AScasing to avoid warnings.Adds a reusable GitHub Actions
docker-buildworkflow and wires it into the maintestsworkflow to build the Docker image in CI.Reviewed by Cursor Bugbot for commit b351af7. Bugbot is set up for automated code reviews on this repo. Configure here.