feat(i18n): extract untranslated frontend UI strings#7976
Open
Chelovedus wants to merge 1 commit intorequarks:scarlettfrom
Open
feat(i18n): extract untranslated frontend UI strings#7976Chelovedus wants to merge 1 commit intorequarks:scarlettfrom
Chelovedus wants to merge 1 commit intorequarks:scarlettfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls a chunk of untranslated UI text out of the frontend and puts it behind the existing i18n lookup. Most of the diff is replacing hardcoded labels, tooltips, notify messages, and fallback errors with
t(...), then adding the missing keys inbackend/locales/en.json.While doing that I also cleaned up a couple of awkward spots in the extraction itself, for example the pending-assets empty state in
PageActionsCol.vueand the helper text wiring inIconPickerDialog.vue.I left
EditorWysiwyg.vuealone. It still has a lot of hardcoded toolbar titles and it would have turned this into a different patch.Checks were simple: parsed
backend/locales/en.jsonafter the key additions, then reran targetedrgsearches against the touched files to catch missed English literals and mismatched key names.I hope that my work will help you!