[BUILD ONLY] Network config wizard step build iso#1234
Draft
rvykydal wants to merge 9 commits intorhinstaller:mainfrom
Draft
[BUILD ONLY] Network config wizard step build iso#1234rvykydal wants to merge 9 commits intorhinstaller:mainfrom
rvykydal wants to merge 9 commits intorhinstaller:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new "Network" configuration step to the installation wizard, primarily for boot ISO installations. The changes include a new NetworkConfiguration component that integrates the Cockpit network manager via an iframe, logic to filter specific UI elements within that iframe using a MutationObserver, and updates to the wizard's step ordering and documentation. Additionally, test helpers were updated to support the new step, and a wait condition was added to ensure sidebar items are enabled before interaction. I have no feedback to provide.
Add a new Network Configuration wizard step between Language and Date/Time pages. The page embeds the cockpit networkmanager module via iframe, reusing the same integration pattern as the existing modal network configuration. Resolves: INSTALLER-4650
Resolves: INSTALLER-4650
Resolves: INSTALLER-4650
Resolves: INSTALLER-4650
Resolves: INSTALLER-4650
Resolves: INSTALLER-4650
We should disable the navigation on wizard sidebar for real when isFormDisabled is true. Currently it is still possible to click away from the screen on the sidebar. This is problematic for example when checkpoint is in progress in network configuration, where destroying the iframe can lead to broken connectivity. Related: INSTALLER-4650
Resolves: INSTALLER-4650
The browser process inherits the stdout pipe from webui-desktop back to anaconda's proc.communicate(). When exitGui() kills webui-desktop, the cleanup trap kills the browser, but Firefox may survive (it forks into its own process group). While Firefox is alive it holds the pipe open, so proc.communicate() never returns, anaconda never exits, and the atexit handler that calls systemctl reboot is never reached. Redirect the browser's stdout/stderr to webui-browser.log file so that even if Firefox outlives webui-desktop, it cannot block anaconda's pipe. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rvykydal
force-pushed
the
network-config-wizard-step-build-iso
branch
from
365bd62 to
a7a9db7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.