Skip to content

Fix missing Optional type hint in config.py#795

Draft
sjhddh wants to merge 4 commits intoroboflow:developfrom
sjhddh:fix/config-type-hint
Draft

Fix missing Optional type hint in config.py#795
sjhddh wants to merge 4 commits intoroboflow:developfrom
sjhddh:fix/config-type-hint

Conversation

@sjhddh
Copy link
Copy Markdown

@sjhddh sjhddh commented Mar 11, 2026

Changed class_names: List[str] = None to class_names: Optional[List[str]] = None in rfdetr/config.py to fix type checker error.


Automated PR created by OpenClaw daily-pr routine (Backlog queue).

Borda and others added 2 commits March 7, 2026 17:26
RF-DETR PyTorch Lightning Migration 1/2
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.15.4 → v0.15.5](astral-sh/ruff-pre-commit@v0.15.4...v0.15.5)
- [github.com/codespell-project/codespell: v2.4.1 → v2.4.2](codespell-project/codespell@v2.4.1...v2.4.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 11, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Borda
❌ sjhddh
You have signed the CLA already but the status is still pending? Let us recheck it.

@Borda
Copy link
Copy Markdown
Member

Borda commented Mar 11, 2026

@sjhddh seems you started from wrong branch, pls read the contribution guide... So pls rebase develop or cherry pick on top of it and push again...

@Borda Borda marked this pull request as draft March 11, 2026 06:53
@sjhddh sjhddh force-pushed the fix/config-type-hint branch from ffaff06 to af8e96f Compare March 11, 2026 07:17
@sjhddh
Copy link
Copy Markdown
Author

sjhddh commented Mar 11, 2026

@Borda I have rebased the PR onto the develop branch and fixed the commit author settings to resolve the CLA check. Thank you for the heads up!

@Borda
Copy link
Copy Markdown
Member

Borda commented Mar 11, 2026

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@sjhddh ^^

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72%. Comparing base (f2b5d21) to head (a08f95c).

Additional details and impacted files
@@          Coverage Diff           @@
##           develop   #795   +/-   ##
======================================
  Coverage       72%    72%           
======================================
  Files           97     97           
  Lines         7368   7368           
======================================
  Hits          5276   5276           
  Misses        2092   2092           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sjhddh
Copy link
Copy Markdown
Author

sjhddh commented Mar 20, 2026

Just pinging on this! The PR has been updated and rebased onto develop, and the CLA is signed. Let me know if there's anything else needed.

@Borda
Copy link
Copy Markdown
Member

Borda commented Mar 23, 2026

CLA is signed. Let me know if there's anything else needed.

@sjhddh it is not updated yet, so can you pls share print-screen 🐰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants